839027 - Kill object typeof hook

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Tom S]

With e4x gone and the window.all hack gone, we are able to remove typeof hacks. Because checking for [[Call]] should to the right thing (TM).

Try run looks good, assuming we have sufficient tests. https://tbpl.mozilla.org/?tree=Try&rev=16f8f8eb81e3

Comment 2

[Tom S]

*remove typeof hooks. *should do the right thing.

Comment 3

[Tom S]

Attachment: remove typeof hook

I just ripped out everything until it compiled. I think we can simplify some JIT code and maybe also remove JSType somehow.

Comment 4

[Jason Orendorff [:jorendorff]]

Comment on attachment 711277 [details] [diff] [review]
remove typeof hook

Review of attachment 711277 [details] [diff] [review]:
-----------------------------------------------------------------

Great!

::: js/xpconnect/src/XPCWrappedNativeJSOps.cpp
@@ +1407,5 @@
> +    // Note: Per Ecmascript only objects with a [[Call]] are typeof "function"
> +    if (mFlags.WantCall())
> +        mJSClass.base.call = XPC_WN_Helper_Call;
> +    if (mFlags.WantConstruct())
> +        mJSClass.base.construct = XPC_WN_Helper_Construct;

The comment added here is rather baffling. Just remove it?

Comment 5

[Tom S]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b9a00a67b749

Comment 6

[Tom S]

I dropped the changes to XPC before check-in.
https://hg.mozilla.org/integration/mozilla-inbound/rev/6b5dc3b3b21c

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b9a00a67b749