839175 - [Build bustage] MediaBufferDecoder.cpp(703) : error C2061: syntax error : identifier 'AudioBuffer'

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Honza Bambas (:mayhemer)]

17:42.12 c:/Mozilla/src/mozilla-central/content/media/webaudio/MediaBufferDecoder.cpp(703) : error C2061: syntax error : identifier 'AudioBuffer'
17:42.12
17:42.12 c:/Mozilla/src/mozilla-central/content/media/webaudio/MediaBufferDecoder.cpp(790) : error C4430: missing type specifier - int assumed. Note: C++ does
 not support default-int
17:42.12
17:42.12 c:/Mozilla/src/mozilla-central/content/media/webaudio/MediaBufferDecoder.cpp(790) : error C2143: syntax error : missing ',' before '&'
17:42.12
17:42.12 c:/Mozilla/src/mozilla-central/content/media/webaudio/MediaBufferDecoder.cpp(794) : error C2511: 'mozilla::WebAudioDecodeJob::WebAudioDecodeJob(const
 nsACString_internal &,const int)' : overloaded member function not found in 'mozilla::WebAudioDecodeJob'
17:42.12
17:42.12         c:\mozilla\src\mozilla-central\content\media\webaudio\MediaBufferDecoder.h(30) : see declaration of 'mozilla::WebAudioDecodeJob'
17:42.12
17:42.12 c:/Mozilla/src/mozilla-central/content/media/webaudio/MediaBufferDecoder.cpp(875) : error C2059: syntax error : '}'
17:42.12
17:42.12 c:/Mozilla/src/mozilla-central/content/media/webaudio/MediaBufferDecoder.cpp(877) : error C2612: trailing 'end of file' illegal in base/member initia
lizer list
17:42.12
17:42.12 c:/Mozilla/src/mozilla-central/content/media/webaudio/MediaBufferDecoder.cpp(877) : fatal error C1004: unexpected end-of-file found


# Options for client.mk.
mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/_obj-browser-debug
mk_add_options MOZ_MAKE_FLAGS=-j9

# Options for 'configure' (same as command-line options).
#ac_add_options --enable-jemalloc

export MOZ_DEBUG_SYMBOLS=1

ac_add_options --enable-application=browser
ac_add_options --enable-debug
ac_add_options --disable-optimize
ac_add_options --enable-shared

ac_add_options --disable-static
ac_add_options --enable-tests
ac_add_options --enable-logging
ac_add_options --enable-visual-event-tracer
ac_add_options --disable-installer
ac_add_options --enable-chrome-format=flat
ac_add_options --disable-crashreporter
ac_add_options --disable-webm
ac_add_options --disable-accessibility
ac_add_options --disable-webgl
ac_add_options --disable-ogg
ac_add_options --disable-webrtc
ac_add_options --disable-dash 

Clobbered build (no other obj dirs), no local patches.
m-c, debug build of a46bc920998d

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I don't get it. We #include "AudioBuffer.h" at the start of that file. Why have we got an error on line 703, I wonder.

Can you get the preprocessed source and attach it here?

Comment 2

[Honza Bambas (:mayhemer)]

Attachment: MediaBufferDecoder.i + MediaBufferDecoder.inc

MediaBufferDecoder.i - the preprocessed file (/P)
MediaBufferDecoder.inc - include files list (/showIncludes)

Usually these problems comes from one of --disable-XX options in mozconfig, usually it is accessibility.

Comment 3

[Honza Bambas (:mayhemer)]

This changeset http://hg.mozilla.org/mozilla-central/rev/083e6703ed56 is the culprit.

Comment 4

[Honza Bambas (:mayhemer)]

Attachment: workaround v1

Some header declares class AudioBuffer as mozilla::dom::AudioBuffer.  Would be nice to figure out which one.

For now using namespace dom; helps.

Comment 5

[Honza Bambas (:mayhemer)]

Comment on attachment 711889 [details] [diff] [review]
workaround v1

https://hg.mozilla.org/integration/mozilla-inbound/rev/20400a35c261

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/20400a35c261