839193 - IndexedDatabaseManager leaks if CancelGetUsageForURI is called before the runnable for GetUsageForURI has been run

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Description

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

I could only reproduce this by repeatedly opening and closing a window that makes a call to IndexedDatabaseManager::GetUsageForURI followed by CancelGetUsageForURI. I think the issue is that in IndexedDatabaseManager::AsyncUsageRunnable::RunInternal, if the runnable has been cancelled, it exits early, meaning that it hangs on mURI and mCallback and never gets removed from mUsageRunnables.

Comment 1

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

Attachment: patch to reproduce bug

after applying this patch and building, running `./mach browser/base/content/test/browser_idbbug.js' should reproduce the bug

Comment 2

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

Attachment: possible fix

this should fix it - I'm not sure if it breaks other things, though

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 711449 [details] [diff] [review]
possible fix

I believe this patch is correct.

There's an even worse bug in here.  Not only does the test case cause a leak, it also prevents opening any more databases from that origin until the browser is restarted.

Comment 4

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

Attachment: test

Just to be clear, does the patch also fix the worse bug you mentioned?
Anyway, I munged the repro patch into something that I think works as a mochitest for indexedDB. If you would let me know if this looks alright, that would be great. Thanks for your responsiveness on this!

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

(In reply to David Keeler (:keeler) from comment #4)
> Created attachment 711612 [details] [diff] [review]
> test
> 
> Just to be clear, does the patch also fix the worse bug you mentioned?

Yes.

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 711612 [details] [diff] [review]
test

Review of attachment 711612 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not really competent to review browser-chrome tests.

Comment 7

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 711612 [details] [diff] [review]
test

Review of attachment 711612 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 8

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

The try run looked good:
https://tbpl.mozilla.org/?tree=Try&rev=c0ed21c1ac11

Checkin:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cf1fa0280708
https://hg.mozilla.org/integration/mozilla-inbound/rev/783d5b18ee7

Thanks, all!

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cf1fa0280708
https://hg.mozilla.org/mozilla-central/rev/783d5b18ee73

Comment 10

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

Comment on attachment 711449 [details] [diff] [review]
possible fix

[Approval Request Comment]
Bug caused by (feature/regressing bug #): indexed db manager
User impact if declined: the test for bug 821892 will leak - if that's going to be uplifted to aurora, we need this too
Testing completed (on m-c, etc.): landed on m-c
Risk to taking this patch (and alternatives if risky): low
String or UUID changes made by this patch: none

Comment 11

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

Comment on attachment 711612 [details] [diff] [review]
test

[Approval Request Comment]
Bug caused by (feature/regressing bug #): indexed db manager
User impact if declined: the test for bug 821892 will leak - if that's going to be uplifted to aurora, we need this too
Testing completed (on m-c, etc.): landed on m-c
Risk to taking this patch (and alternatives if risky): low
String or UUID changes made by this patch: none

Comment 12

[Lukas Blakk [:lsblakk] use ?needinfo]

taking this for uplift to go along with bug 821892 - which we want on Aurora.

Comment 13

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/9b6f9b97e938
https://hg.mozilla.org/releases/mozilla-aurora/rev/e841c66bde34