Closed
Bug 83936
Opened 23 years ago
Closed 23 years ago
cookie tests are built even with DISABLE_TESTS=1 set
Categories
(Core :: Networking: Cookies, defect)
Tracking
()
VERIFIED
FIXED
mozilla1.0
People
(Reporter: bryner, Assigned: morse)
References
Details
extensions\cookie\makefile.win should not build in the tests directory if you have DISABLE_TESTS=1 defined in the environment. The DIRS= line needs to be wrapped like this: !if !defined(DISABLE_TESTS) DIRS=tests !endif
Assignee | ||
Comment 1•23 years ago
|
||
Silly not to fix this since reporter already gave us the patch. r=morse cc'ing alecf for superreview
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.2
Comment 2•23 years ago
|
||
Not a Netscape stopper, moving to mozilla1.0 milestone. I'd like to keep the m0.9.2 milestone only on the stoppers.
Target Milestone: mozilla0.9.2 → mozilla1.0
Comment 3•23 years ago
|
||
You never actually added me to the CC but sr=alecf
Comment 4•23 years ago
|
||
a= asa@mozilla.org for checkin to the trunk. (on behalf of drivers)
Blocks: 83989
Assignee | ||
Comment 5•23 years ago
|
||
fix checked in
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
V/fixed: This code appears to be gone now, per lxr.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•