cookie tests are built even with DISABLE_TESTS=1 set

VERIFIED FIXED in mozilla1.0

Status

()

Core
Networking: Cookies
VERIFIED FIXED
17 years ago
14 years ago

People

(Reporter: Brian Ryner (not reading), Assigned: Stephen P. Morse)

Tracking

Trunk
mozilla1.0
x86
Windows 2000
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

17 years ago
extensions\cookie\makefile.win should not build in the tests directory if you
have DISABLE_TESTS=1 defined in the environment.  The DIRS= line needs to be
wrapped like this:

!if !defined(DISABLE_TESTS)
DIRS=tests
!endif
(Assignee)

Comment 1

17 years ago
Silly not to fix this since reporter already gave us the patch.

r=morse

cc'ing alecf for superreview
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.2
Not a  Netscape stopper, moving to mozilla1.0 milestone. I'd like to keep the
m0.9.2 milestone only on the stoppers. 
Target Milestone: mozilla0.9.2 → mozilla1.0

Comment 3

17 years ago
You never actually added me to the CC
but sr=alecf

Comment 4

17 years ago
a= asa@mozilla.org for checkin to the trunk.
(on behalf of drivers)
Blocks: 83989
(Assignee)

Comment 5

17 years ago
fix checked in
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 6

14 years ago
V/fixed:
This code appears to be gone now, per lxr.
Status: RESOLVED → VERIFIED

Updated

14 years ago
QA Contact: tever → benc
You need to log in before you can comment on or make changes to this bug.