839371 - Implement HTML5 <data> element

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[David Humphrey (:humph)]

Related to the <time> element from bug 629801, "The data element represents its contents, along with a machine-readable form of those contents in the value attribute."

interface HTMLDataElement : HTMLElement {
           attribute DOMString value;
};

Is it OK to do this one now too, or should we wait? (spec doc says, "Experimental draft").  If 'yes' I'll do it now as I finish up <time>.  I think both are going to be pretty useful.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Henri, you might know the answer. How stable is the spec?

Comment 2

[Hixie (not reading bugmail)]

I'm not aware of any relevant implementation-affecting outstanding feedback for <data>, for what it's worth.

Comment 3

[David Humphrey (:humph)]

Attachment: v1

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 718095 [details] [diff] [review]
v1


>+JSObject*
>+HTMLDataElement::WrapNode(JSContext* cx, JSObject* scope, bool* triedToWrap)
aCx, aScope, aTriedToWrap

Comment 5

[David Humphrey (:humph)]

Attachment: v2 (r=smaug)

I've fixed that nit, thanks for the quick review.

Do you want anyone else to look at this, or can it land?

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

I think this should be fine.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4d3e8e7ee977

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/4d3e8e7ee977

Comment 9

[Mihaela Velimiroviciu (:mihaelav)]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:22.0) Gecko/20130403 Firefox/22.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:22.0) Gecko/20130403 Firefox/22.0
Mozilla/5.0 (X11; Linux i686; rv:22.0) Gecko/20130402 Firefox/22.0
BuildID: 20130402004013

I also performed some testing around this element on latest Firefox 22 Aurora builds across main platforms and there were no related visual issues or errors on pages using the <data> tag.
Based on this and the fact that there is a test page for this element, I'm marking the bug Verified.

Comment 10

[Alex Keybl [:akeybl]]

This bug has been listed as part of the Aurora 22 release notes in either [1], [2], or both. If you find any of the information or wording incorrect in the notes, please email [e-mail] asap. Thanks!

[1] https://www.mozilla.org/en-US/firefox/22.0a2/auroranotes/
[2] https://www.mozilla.org/en-US/mobile/22.0a2/auroranotes/

Comment 11

[Jean-Yves Perrier [:teoli]]

Documented:
https://developer.mozilla.org/en-US/docs/Web/API/HTMLDataElement
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/data
and
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/22