839384 - Fix build warnings for DrawTargetCG

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Daniel Holbert [:dholbert]]

DrawTargetCG.h/cpp has these build warnings:
{
gfx/2d/DrawTargetCG.cpp:125:32: warning: field 'mSnapshot' will be initialized after field 'mCg' [-Wreorder]
gfx/2d/DrawTargetCG.h:154:10: warning: private field 'mIOSurfaceTexture' is not used [-Wunused-private-field]
}

Filing this bug on fixing those.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: fix (now w/ added parens to fix warning about &&/|| expression)

oh, I missed these warnings:
{
gfx/2d/DrawTargetCG.cpp:1032:41: warning: '&&' within '||' [-Wlogical-op-parentheses]
gfx/2d/DrawTargetCG.cpp:1032:41: note: place parentheses around the '&&' expression to silence this warning

gfx/2d/DrawTargetCG.cpp:1033:53: warning: '&&' within '||' [-Wlogical-op-parentheses]
/gfx/2d/DrawTargetCG.cpp:1033:53: note: place parentheses around the '&&' expression to silence this warning
}

Updated the patch to fix those as well.

Comment 3

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/594944f54c72

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/594944f54c72