839420 - Don't call cx->stack.spIndexOf in ReportIsNotFunction

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jan de Mooij [:jandem]]

ReportIsNotFunction does

    ptrdiff_t spIndex = cx->stack.spIndexOf(vp);

To determine where vp is on the interpreter stack. Pretty gross and this hack is not going to work with the baseline compiler because (1) it doesn't use the interpreter stack and (2) it copies values on the stack (stack grows down so we have to reverse the arguments vector).

Not sure yet what's the easiest way to fix this.

This is causing expression-autopsy.js test failures on the baseline compiler branch.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Patch

This fixes the expression-autopsy test failure and passes tests on inbound.

Comment 2

[Brian Hackett [Laid off!]]

Comment on attachment 711812 [details] [diff] [review]
Patch

Review of attachment 711812 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsinterp.h
@@ +109,4 @@
>  
>  extern JSObject *
> +ValueToCallable(JSContext *cx, const Value &vp, int numToSkip = -1,
> +                MaybeConstruct construct = NO_CONSTRUCT);

The meaning of numToSkip in these two functions needs a comment.

Comment 3

[Jan de Mooij [:jandem]]

Pushed with comment addressed:

https://hg.mozilla.org/integration/mozilla-inbound/rev/e644bc44f39f

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e644bc44f39f