839514 - Port checkForCrashes() change from bug 813577 to mozcrash

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Ed Morley [:emorley]]

This hunk:
https://bugzilla.mozilla.org/attachment.cgi?id=693170&action=diff#a/build/automationutils.py_sec1

Comment 1

[Ed Morley [:emorley]]

Attachment: Patch v1

Is only really a two line change, once whitespace excluded.

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 711864 [details] [diff] [review]
Patch v1

Review of attachment 711864 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, but this needs to land in the github repo.

Comment 3

[Ed Morley [:emorley]]

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #2)
> Comment on attachment 711864 [details] [diff] [review]
> Patch v1
> 
> Review of attachment 711864 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=me, but this needs to land in the github repo.

Yup, it's a git diff from the github repo.

Comment 4

[Jeff Hammel]

can/should i land this? should we mirror it to m-c soon(ish)?

Comment 5

[Ed Morley [:emorley]]

(In reply to Jeff Hammel [:jhammel] from comment #4)
> can/should i land this? should we mirror it to m-c soon(ish)?

I've just landed this, but thank you for the offer :-)

https://github.com/mozilla/mozbase/commit/f143c6a26fce967858c7f5fd711434ddc545693f

I don't think there is a huge rush to mirror it to m-c, as long as we make sure we're up to date before Joel finishes the switch to mozcrash.

Comment 6

[Jeff Hammel]

(In reply to Ed Morley [:edmorley UTC+0] from comment #5)
> (In reply to Jeff Hammel [:jhammel] from comment #4)
> > can/should i land this? should we mirror it to m-c soon(ish)?
> 
> I've just landed this, but thank you for the offer :-)
> 
> https://github.com/mozilla/mozbase/commit/
> f143c6a26fce967858c7f5fd711434ddc545693f
> 
> I don't think there is a huge rush to mirror it to m-c, as long as we make
> sure we're up to date before Joel finishes the switch to mozcrash.

Sounds like a plan.  Let's collectively not forget

Comment 7

[Joel Maher ( :jmaher ) (UTC -8) (PTO back normal Nov 17)]

I verified the other day (the 13th I believe) that mozcrash is in parity with automationutils.py.  So far so good.  

Next week we might get the 'make leaktest' code up and running, and if so, we can move forward with mozcrash goodness.