Port checkForCrashes() change from bug 813577 to mozcrash

RESOLVED FIXED

Status

Testing
Mozbase
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: emorley, Assigned: emorley)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Comment 1

5 years ago
Created attachment 711864 [details] [diff] [review]
Patch v1

Is only really a two line change, once whitespace excluded.
Attachment #711864 - Flags: review?(ted)
Comment on attachment 711864 [details] [diff] [review]
Patch v1

Review of attachment 711864 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, but this needs to land in the github repo.
Attachment #711864 - Flags: review?(ted) → review+
(Assignee)

Comment 3

5 years ago
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #2)
> Comment on attachment 711864 [details] [diff] [review]
> Patch v1
> 
> Review of attachment 711864 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=me, but this needs to land in the github repo.

Yup, it's a git diff from the github repo.

Comment 4

5 years ago
can/should i land this? should we mirror it to m-c soon(ish)?
(Assignee)

Comment 5

5 years ago
(In reply to Jeff Hammel [:jhammel] from comment #4)
> can/should i land this? should we mirror it to m-c soon(ish)?

I've just landed this, but thank you for the offer :-)

https://github.com/mozilla/mozbase/commit/f143c6a26fce967858c7f5fd711434ddc545693f

I don't think there is a huge rush to mirror it to m-c, as long as we make sure we're up to date before Joel finishes the switch to mozcrash.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Comment 6

5 years ago
(In reply to Ed Morley [:edmorley UTC+0] from comment #5)
> (In reply to Jeff Hammel [:jhammel] from comment #4)
> > can/should i land this? should we mirror it to m-c soon(ish)?
> 
> I've just landed this, but thank you for the offer :-)
> 
> https://github.com/mozilla/mozbase/commit/
> f143c6a26fce967858c7f5fd711434ddc545693f
> 
> I don't think there is a huge rush to mirror it to m-c, as long as we make
> sure we're up to date before Joel finishes the switch to mozcrash.

Sounds like a plan.  Let's collectively not forget
I verified the other day (the 13th I believe) that mozcrash is in parity with automationutils.py.  So far so good.  

Next week we might get the 'make leaktest' code up and running, and if so, we can move forward with mozcrash goodness.
You need to log in before you can comment on or make changes to this bug.