Closed
Bug 839569
Opened 12 years ago
Closed 12 years ago
mozbase modules from tests.zip are not extracted during test time
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jmaher, Assigned: jmaher)
References
Details
Attachments
(1 file)
754 bytes,
patch
|
armenzg
:
review+
armenzg
:
checked-in+
|
Details | Diff | Splinter Review |
in order for our test harnesses to use mozbase modules, we need to unzip them, right now we only unzip things that are related to the harness:
http://hg.mozilla.org/build/buildbotcustom/file/9b23b69f1947/steps/misc.py#l274
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #711901 -
Flags: review?(armenzg)
Comment 2•12 years ago
|
||
Comment on attachment 711901 [details] [diff] [review]
add mozbase* to the subdirs we extra from the tests.zip file (1.0)
Review of attachment 711901 [details] [diff] [review]:
-----------------------------------------------------------------
Is mozbase supposed to be on all package tests for older branches as well?
Attachment #711901 -
Flags: review?(armenzg) → review+
Assignee | ||
Comment 3•12 years ago
|
||
we won't be using it specifically, it is just when a testharness or tool needs to import it. Are you concerned that there might be errors in unzipping mozbase* ?
Comment 4•12 years ago
|
||
That is my concern.
The following checks clear my concerns.
mozilla-release has it: http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-release-linux/1360193673/firefox-18.0.2.en-US.linux-i686.tests.zip
mozillaesr17 has it: http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-esr17-linux/1360347673/firefox-17.0.2esrpre.en-US.linux-i686.tests.zip
I'm happy to land it since those 2 branches already have it.
Assignee | ||
Comment 5•12 years ago
|
||
http://hg.mozilla.org/build/buildbotcustom/rev/b3ba4d217f62
waiting for deployment before closing.
Comment 6•12 years ago
|
||
in production
Assignee | ||
Comment 7•12 years ago
|
||
can we close this now?
Updated•12 years ago
|
Attachment #711901 -
Flags: checked-in+
Comment 8•12 years ago
|
||
Yes. Thanks for your help!
Assignee: nobody → jmaher
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Product: mozilla.org → Release Engineering
Updated•7 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•