839574 - gaia HEAD stuck at "Based on Mozilla Technology" screen (Desktop B2G)

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Rick Waldron [:rwaldron]]

HEAD no longer gets past the "Based on Mozilla Technology" screen. I've bisected twice, from two different good commits and both times this commit was identified:

-----------------------------
fba586f468f6ac035f5c3e61e25e43d8fea7896f is the first bad commit
commit fba586f468f6ac035f5c3e61e25e43d8fea7896f
Author: Vivien Nicolas <[e-mail]>
Date:   Thu Feb 7 16:05:18 2013 +0100

    Bug 837111 - Minify js source. r=ochameau

:040000 040000 747f2899de685d29c7505b3ff3765b5a069afc96 29f083292a7b7c9dc3b2313fbb14b6a6557fff20 M	build
-----------------------------

I didn't encounter this yesterday because my local `837267` branch started from c0c1217639bd1adf469d4da0d05d43daca9d4c14, so it worked fine; prior to it being merged 687a9b69381e24391c417bcbdd8e0c04e93e8259 I rebased, but didn't bother to build and run because there were no issues with the rebase, so again I missed the issue.

Comment 1

[Rick Waldron [:rwaldron]]

Attachment: Fix for 839574

https://github.com/mozilla-b2g/gaia/pull/8030

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 711909 [details] [diff] [review]
Fix for 839574

You will likely need to rebase since a fix has just landed because it was regressing fb import too.

Comment 3

[Rick Waldron [:rwaldron]]

rebased, but also added relevant link to the other blacklist item

Comment 4

[Alex Keybl [:akeybl]]

Bug 837111 hasn't landed on v1-train, so not blocking yet.

Comment 5

[Julien Wajsberg [:julienw]]

This landed in https://github.com/mozilla-b2g/gaia/commit/6d5a4949a1357296750cb15bf7f3374c78607004

Comment 4 implies this was supposed to go on v1-train too, so asking for tracking?.
(for sure we could use a working b2g-desktop on v1-train, and even on v1.0.1)

Comment 6

[Michael Vines [:m1] [:evilmachines]]

(tef- because bug 837111 is also tef-)

Comment 7

[Julien Wajsberg [:julienw]]

Marking resolved/fixed because this landed in master.

Comment 8

[Michael Vines [:m1] [:evilmachines]]

(ok, we're taking bug 837111 now)

Comment 9

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train and v1.0.1.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train and v1.0.1, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 6d5a4949a1357296750cb15bf7f3374c78607004
  <RESOLVE MERGE CONFLICTS>
  git commit
  git checkout v1.0.1
  git cherry-pick -x $(git log -n1 v1-train)

Comment 10

[Julien Wajsberg [:julienw]]

v1-train: 69dbcd84085f10bec0c0189b926ffb535b14dcfe

Comment 11

[Julien Wajsberg [:julienw]]

v1.0.1: 2c245ecb1eb648b0978d31eab9b8aaf21559fb73

Comment 12

[amiller]

Does not make sense to create a regression issue.

Comment 13

[Jeni]

Can you please provide steps to verify this fix - as we will blackbox test from the UI?

Comment 14

[Rick Waldron [:rwaldron]]

1. Turn on device
2. Observe "Based on Mozilla Technology" screen
3. Observe either FTU or Homescreen

Comment 15

[Jeni]

Verified fixed on 
Unagi Build ID: 20130401070203
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/b28463f2e718
Gaia: ddb38ac8a34f9e30e09d0ff3b5c1bfb9b664b7c3

and

Unagi Build ID: 20130401070203
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/f9f11b8cbf8a
Gaia: 663101b6eb809383e5882d9bc3868a923a57998a

On Unagi devices the "Based on Mozilla Technology" screen is working.