839625 - Incoming rotate events while image is snapping are mishandled

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Brandon Waterloo]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:21.0) Gecko/20130205 Firefox/21.0
Build ID: 20130205153002

Steps to reproduce:

When rotating an image, there is a 0.3s snap to the nearest 90.  If, during this 0.3s time period, a new rotation gesture is performed, behavior gets weird


Actual results:

e.g., the image may rotate 270 degrees in the wrong direction instead of 90 degrees in the right direction.
Other odd behavior may occur


Expected results:

Either:
1)  New rotation gestures should be ignored while snapping, or
2)  Snapping should cease, and behavior should return to being locked to the gesture.

--As the implementer of rotation, the first of these two options would be much easier to do.

Comment 1

[Brandon Waterloo]

Attachment: Propose patch, ignore incoming events until snapping is done

This patch proposed will check to see if an end-of-rotation snapping is occurring (by checking for the completeRotation class on the image element), and if so, it will ignore new MozRotateGestureUpdate and MozRotateGesture events.

If the class is not present, the behavior is the same as before.

Comment 2

[Brandon Waterloo]

This bug will be fixed by the patch for bug 840584.  Separating the patches was a bit more challenging than it was worth.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 712134 [details] [diff] [review]
Propose patch, ignore incoming events until snapping is done

Review of attachment 712134 [details] [diff] [review]:
-----------------------------------------------------------------

I left feedback for this patch in the other bug.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bad7ced53bef

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/mozilla-central/rev/bad7ced53bef