Closed
Bug 839648
Opened 11 years ago
Closed 11 years ago
Clean up testGreyLarry.js in default and aurora branches
Categories
(Mozilla QA Graveyard :: Mozmill Tests, defect, P5)
Mozilla QA Graveyard
Mozmill Tests
Tracking
(firefox18 unaffected, firefox19 unaffected, firefox20 fixed, firefox21 fixed, firefox-esr17 unaffected)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox18 | --- | unaffected |
firefox19 | --- | unaffected |
firefox20 | --- | fixed |
firefox21 | --- | fixed |
firefox-esr17 | --- | unaffected |
People
(Reporter: jfrench, Unassigned)
References
()
Details
Attachments
(1 file)
1.27 KB,
patch
|
davehunt
:
review+
davehunt
:
checkin+
|
Details | Diff | Splinter Review |
Begat from Comment 100 in Bug 789916: https://bugzilla.mozilla.org/show_bug.cgi?id=789916#c100 // Check the favicon has no label > The patch on bug 803088 missed to remove that for > the default and aurora branch. So, I'd like to clean up the noted line, in testGreyLarry.js in default and aurora. Please assign me as programmer if appropriate. This will allow small patches which involve this file to be landed on all branches without requiring a subtly different patch. And to prevent the line from being accidentally propagated back to beta, release, and esr17.
Reporter | ||
Comment 1•11 years ago
|
||
I've built a patch in advance of the bug being assigned. I will attach it momentarily.
Reporter | ||
Comment 2•11 years ago
|
||
Patch "clean up greyLarry (default and aurora)" for those respective branches. One file affected. Tested with Default Nightly 21.0a1 20130211031055. Tested with Aurora 20.0a2 20130211042016. Tests pass as expected, in both branches and builds.
Attachment #712488 -
Flags: review?
Reporter | ||
Updated•11 years ago
|
Attachment #712488 -
Flags: review? → review?(dave.hunt)
Comment 3•11 years ago
|
||
Comment on attachment 712488 [details] [diff] [review] clean up greyLarry (default and aurora) Review of attachment 712488 [details] [diff] [review]: ----------------------------------------------------------------- Thanks Jonathan, looks great! Landed as: http://hg.mozilla.org/qa/mozmill-tests/rev/4fdf37e044ae (default) http://hg.mozilla.org/qa/mozmill-tests/rev/908006f1baba (mozilla-aurora)
Attachment #712488 -
Flags: review?(dave.hunt)
Attachment #712488 -
Flags: review+
Attachment #712488 -
Flags: checkin+
Updated•11 years ago
|
Status: UNCONFIRMED → RESOLVED
Closed: 11 years ago
status-firefox18:
--- → unaffected
status-firefox19:
--- → unaffected
status-firefox20:
--- → fixed
status-firefox21:
--- → fixed
status-firefox-esr17:
--- → unaffected
Resolution: --- → FIXED
Updated•5 years ago
|
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•