Closed Bug 839648 Opened 11 years ago Closed 11 years ago

Clean up testGreyLarry.js in default and aurora branches

Categories

(Mozilla QA Graveyard :: Mozmill Tests, defect, P5)

defect

Tracking

(firefox18 unaffected, firefox19 unaffected, firefox20 fixed, firefox21 fixed, firefox-esr17 unaffected)

RESOLVED FIXED
Tracking Status
firefox18 --- unaffected
firefox19 --- unaffected
firefox20 --- fixed
firefox21 --- fixed
firefox-esr17 --- unaffected

People

(Reporter: jfrench, Unassigned)

References

()

Details

Attachments

(1 file)

Begat from Comment 100 in Bug 789916:
https://bugzilla.mozilla.org/show_bug.cgi?id=789916#c100

// Check the favicon has no label

> The patch on bug 803088 missed to remove that for
> the default and aurora branch.

So, I'd like to clean up the noted line, in testGreyLarry.js in default and aurora. Please assign me as programmer if appropriate. This will allow small patches which involve this file to be landed on all branches without requiring a subtly different patch. And to prevent the line from being accidentally propagated back to beta, release, and esr17.
I've built a patch in advance of the bug being assigned. I will attach it momentarily.
Patch "clean up greyLarry (default and aurora)" for those respective branches. One file affected.

Tested with Default Nightly 21.0a1 20130211031055.
Tested with Aurora 20.0a2 20130211042016.

Tests pass as expected, in both branches and builds.
Attachment #712488 - Flags: review?
Attachment #712488 - Flags: review? → review?(dave.hunt)
Comment on attachment 712488 [details] [diff] [review]
clean up greyLarry (default and aurora)

Review of attachment 712488 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Jonathan, looks great!

Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/4fdf37e044ae (default)
http://hg.mozilla.org/qa/mozmill-tests/rev/908006f1baba (mozilla-aurora)
Attachment #712488 - Flags: review?(dave.hunt)
Attachment #712488 - Flags: review+
Attachment #712488 - Flags: checkin+
Status: UNCONFIRMED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: