The default bug view has changed. See this FAQ.

Remove usage of gXULAppInfo and createAppInfo in toolkit/components/search/tests/xpcshell/

RESOLVED FIXED in Firefox 21

Status

()

Firefox
Search
--
minor
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: MattN, Assigned: Joshua Kalpin)

Tracking

Trunk
Firefox 21
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mentor=MattN][lang=js], URL)

Attachments

(1 attachment, 2 obsolete attachments)

Since bug 809920 landed, we can use updateAppInfo from AppInfo.jsm[1].

[1] https://developer.mozilla.org/en-US/docs/Using_nsIXULAppInfo#Getting_nsIXULAppInfo_in_xpcshell_tests
(Assignee)

Comment 1

4 years ago
First bug for me but I think I should be able to handle it if it hasn't been claimed yet.
Excellent! Let me know if you have any questions.
Assignee: nobody → joshua.kalpin
Status: NEW → ASSIGNED
(Assignee)

Comment 3

4 years ago
Created attachment 714239 [details] [diff] [review]
First patch to remove createAppInfo

First attempt at the replacement. Not 100% sure if I did it quite right.
Comment on attachment 714239 [details] [diff] [review]
First patch to remove createAppInfo

Review of attachment 714239 [details] [diff] [review]:
-----------------------------------------------------------------

Excellent work on your first patch! Only a few comments to address below.

Could you update your .hgrc file to include the username field so that it gets included in the commit message? See https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F

Once you make these changes, go ahead an upload another version in this bug and set the checkin flag to '?' and I will push the patch.

Thanks!

::: toolkit/components/search/tests/xpcshell/head_search.js
@@ -14,1 @@
>  const BROWSER_SEARCH_PREF = "browser.search.";

Could you also remove the definitions of XULAPPINFO_CONTRACTID and XULAPPINFO_CID above this?

::: toolkit/components/search/tests/xpcshell/test_645970.js
@@ +7,5 @@
>  /**
>   * Test nsSearchService with nested jar: uris, without async initialization
>   */
>  function run_test() {
> +  updateAppInfo();  

Nit: there is trailing whitespace on this line.
Attachment #714239 - Flags: review+
(Assignee)

Comment 5

4 years ago
Created attachment 714350 [details] [diff] [review]
Second patch
Attachment #714350 - Flags: checkin?(joshua.kalpin)
(Assignee)

Comment 6

4 years ago
Created attachment 714351 [details] [diff] [review]
Actual second patch

Goofed on the first file upload. This is the correct one.
Attachment #714239 - Attachment is obsolete: true
Attachment #714350 - Attachment is obsolete: true
Attachment #714350 - Flags: checkin?(joshua.kalpin)
Attachment #714351 - Flags: checkin?
Comment on attachment 714351 [details] [diff] [review]
Actual second patch

In my landing queue. In the future, please use the checkin-needed keyword at the top instead (we typically use checkin? for bugs with multiple attached patches and only a subset needing checkin).
Attachment #714351 - Flags: checkin?
But thank you for the patch!
https://hg.mozilla.org/integration/mozilla-inbound/rev/6f47066fa6fd
https://hg.mozilla.org/mozilla-central/rev/6f47066fa6fd
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 21
You need to log in before you can comment on or make changes to this bug.