839695 - (context-menu) error during test: "The Components object is deprecated."

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P2)

Description

[Erik Vold [:erikvold] (please needinfo? me)]

When I run `cfx test -f context` I see the following message twice:

info: addon-sdk: [JavaScript Error: "The Components object is deprecated. It will soon be removed." {file: "javascript:self.on("click", function (node, data) {  let Ci = Components["interfaces"];  self.postMessage({    tagName: node.tagName,    data: data  });});" line: 1}]

there seems to be a `let Ci = Components["interfaces"];` line that is unused in the context-menu tests that is causing this.

Comment 1

[Dave Townsend [:mossop]]

I never really figured out what that was doing there, it's been in the tests for a long time. I assumed it was testing that the content script could use the Components object for some reason but I didn't dig much further.

Comment 2

[Dave Townsend [:mossop]]

These lines should have been removed as a part of bug 732716

Comment 3

[Dave Townsend [:mossop]]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/791

Pointer to Github pull-request

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/75b55a06d6bdba138f253a87fca6005f1ef31b97
Bug 839695: Remove deprecated Components usage left over from bug 732716.

https://github.com/mozilla/addon-sdk/commit/1afc3d73c6e20dc88e9aba91c6ff499d4fcf69ad
Merge pull request #791 from Mossop/bug839695

Fix Bug 839695: Remove deprecated Components usage left over from bug 732716 r=@erikvold

Comment 5

[[github robot]]

Commits pushed to stabilization at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/75b55a06d6bdba138f253a87fca6005f1ef31b97
Bug 839695: Remove deprecated Components usage left over from bug 732716.

https://github.com/mozilla/addon-sdk/commit/1afc3d73c6e20dc88e9aba91c6ff499d4fcf69ad
Merge pull request #791 from Mossop/bug839695