Closed Bug 839831 Opened 7 years ago Closed 7 years ago

jsjni_ functions should be usable without MOZILLA_INTERNAL_API (e.g. in WebRTC code)

Categories

(Firefox for Android :: General, enhancement)

ARM
Android
enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 23

People

(Reporter: dmose, Assigned: gcp)

References

(Blocks 1 open bug)

Details

(Whiteboard: [android-trunk-needed][android-gum+][qa-])

Attachments

(1 file, 1 obsolete file)

Right now, using things like jsjni_FindClass requires including AndroidBridge.h, which blows up because of internal string glop if it's include where MOZILLA_INTERNAL_API isn't defined.  gcp put together a patch that puts them in their own files and exports them independently.
Landed on alder:

https://hg.mozilla.org/projects/alder/rev/fd3a3e5d72e3

Next steps: rebase to trunk and request review.
Whiteboard: [android-trunk-needed]
Attachment #712211 - Attachment description: move jsjni_ functions into their own files, v1 → move jsjni_ functions into their own files, v1 (landed alder)
Blocks: 839836
Whiteboard: [android-trunk-needed] → [android-trunk-needed][android-gum+]
Rebased to m-c.
Attachment #712211 - Attachment is obsolete: true
Attachment #726206 - Flags: review?(blassey.bugs)
Attachment #726206 - Flags: review?(blassey.bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/6354187a454d
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
Whiteboard: [android-trunk-needed][android-gum+] → [android-trunk-needed][android-gum+][qa-]
You need to log in before you can comment on or make changes to this bug.