Closed Bug 839841 Opened 9 years ago Closed 9 years ago
make video engine load Android capture classes correctly by using Get
Global Class Ref
No description provided.
Updated to remove changes to unused Java rendering code, and simply get rid of unused global rooting code, rather than #if 0 to hide it from the compiler. Before uplift, still needs at least one leak fix (marked XXX in the code), and auditing that we're not leaking anything else new.
Attachment #712221 - Attachment is obsolete: true
Landed on alder: https://hg.mozilla.org/projects/alder/rev/e7e7ffda661f Next steps: * rebase to trunk * clean up and audit for leakage * request review.
Attachment #712269 - Attachment description: WIP class-loading patch, v2 → WIP class-loading patch, v2 (landed on Alder)
Whiteboard: [android-trunk-needed] → [android-trunk-needed][blocking-gum-]
Whiteboard: [android-trunk-needed][blocking-gum-] → [android-trunk-needed][blocking-gum-][android-gum+]
Rebased, fixed leaks.
can you explain why this patch is needed (i.e. the problem it is solving)?
This patches switches the code from JNI FindClass to our "non-main-thread" FindClass replacement introduced in a previous patch (and deals with freeing the global ref). This is needed because unlike the webrtc.org code we aren't running WebRTC stuff in the main thread.
Attachment #731889 - Flags: review?(blassey.bugs) → review+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Whiteboard: [android-trunk-needed][blocking-gum-][android-gum+] → [android-trunk-needed][blocking-gum-][android-gum+][qa-]
You need to log in before you can comment on or make changes to this bug.