make video engine load Android capture classes correctly by using GetGlobalClassRef

RESOLVED FIXED in mozilla23

Status

()

defect
--
major
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: dmose, Assigned: dmose)

Tracking

(Blocks 1 bug)

Trunk
mozilla23
ARM
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [android-trunk-needed][blocking-gum-][android-gum+][qa-])

Attachments

(1 attachment, 2 obsolete attachments)

Posted patch WIP class-loading patch, v1 (obsolete) — Splinter Review
No description provided.
Depends on: 835973
Updated to remove changes to unused Java rendering code, and simply get rid of unused global rooting code, rather than #if 0 to hide it from the compiler.

Before uplift, still needs at least one leak fix (marked XXX in the code), and auditing that we're not leaking anything else new.
Attachment #712221 - Attachment is obsolete: true
Landed on alder:

https://hg.mozilla.org/projects/alder/rev/e7e7ffda661f

Next steps:

* rebase to trunk
* clean up and audit for leakage
* request review.
Whiteboard: [android-trunk-needed]
Attachment #712269 - Attachment description: WIP class-loading patch, v2 → WIP class-loading patch, v2 (landed on Alder)
Blocks: 839907
Whiteboard: [android-trunk-needed] → [android-trunk-needed][blocking-gum-]
Whiteboard: [android-trunk-needed][blocking-gum-] → [android-trunk-needed][blocking-gum-][android-gum+]
Rebased, fixed leaks.
Attachment #712269 - Attachment is obsolete: true
Attachment #731889 - Flags: review?(blassey.bugs)
can you explain why this patch is needed (i.e. the problem it is solving)?
This patches switches the code from JNI FindClass to our "non-main-thread" FindClass replacement introduced in a previous patch (and deals with freeing the global ref). This is needed because unlike the webrtc.org code we aren't running WebRTC stuff in the main thread.
Attachment #731889 - Flags: review?(blassey.bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/18670d48447f
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Whiteboard: [android-trunk-needed][blocking-gum-][android-gum+] → [android-trunk-needed][blocking-gum-][android-gum+][qa-]
You need to log in before you can comment on or make changes to this bug.