839841 - make video engine load Android capture classes correctly by using GetGlobalClassRef

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect)

Description

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: WIP class-loading patch, v1

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: WIP class-loading patch, v2 (landed on Alder)

Updated to remove changes to unused Java rendering code, and simply get rid of unused global rooting code, rather than #if 0 to hide it from the compiler.

Before uplift, still needs at least one leak fix (marked XXX in the code), and auditing that we're not leaking anything else new.

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Landed on alder:

https://hg.mozilla.org/projects/alder/rev/e7e7ffda661f

Next steps:

* rebase to trunk
* clean up and audit for leakage
* request review.

Comment 3

[Gian-Carlo Pascutto [:gcp]]

Attachment: Patch 1. Get global refs to the Android capture classes

Rebased, fixed leaks.

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

can you explain why this patch is needed (i.e. the problem it is solving)?

Comment 5

[Gian-Carlo Pascutto [:gcp]]

This patches switches the code from JNI FindClass to our "non-main-thread" FindClass replacement introduced in a previous patch (and deals with freeing the global ref). This is needed because unlike the webrtc.org code we aren't running WebRTC stuff in the main thread.

Comment 6

[Gian-Carlo Pascutto [:gcp]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/18670d48447f

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/18670d48447f