839887 - Regression: Selecting a Synced tab, opens the regular tab menu

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Currently when one selects a synced tab, the regular tab menu will open and the tab panel does not close.

--
Nightly (02/10)
LG Nexus 4 (Android 4.2)

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Let's fix this soon since it is in Aurora too

Comment 2

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

Wrong threading :(
areTabsShown() was accessing a stale value from a different thread, before the animation was bound to happen. So, that caused the SELECTED tab event to queue up a showTabs().

Comment 3

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/265796431ef9

Comment 4

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 713608 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Patch to switch between normal and private tabs on tablets.
User impact if declined: Selecting the synced tab will open the tab, close the tabs ui, and open it again.
Testing completed (on m-c, etc.): Landed in m-i on 02/14
Risk to taking this patch (and alternatives if risky): None. Made sure the thread access is right.
String or UUID changes made by this patch: None.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/265796431ef9

Comment 6

[bhavana bajaj [:bajaj]]

(In reply to Sriram Ramasubramanian [:sriram] from comment #4)
> Comment on attachment 713608 [details] [diff] [review]
> Patch
> 
> [Approval Request Comment]
> Bug caused by (feature/regressing bug #): Patch to switch between normal and
> private tabs on tablets.

regressing bug# : https://bugzilla.mozilla.org/show_bug.cgi?id=834399

Comment 7

[bhavana bajaj [:bajaj]]

Comment on attachment 713608 [details] [diff] [review]
Patch

Low risk fix for a Fx20 regression. Approving on Aurora.PLease land before 2/18.

Adding verifyme and requesting QA verification here . Thanks !

Comment 8

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e10a2597dc1f

Comment 9

[Kevin Brosnan [Ex-Mozilla]]

This is fixed on every channel before it made it to beta. I don't think we need to relnote this.