Closed
Bug 839890
Opened 11 years ago
Closed 11 years ago
Typo at line 391 in gDevTools.jsm
Categories
(DevTools :: Framework, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 22
People
(Reporter: Optimizer, Assigned: Optimizer)
References
Details
Attachments
(1 file)
|
1.15 KB,
patch
|
paul
:
review+
|
Details | Diff | Splinter Review |
Most probably caused by Bug 832984 . At line 391 it should be element.key as the tools definition uses key . This gives the following error while reinstalling Timeline when its already installed once . Timestamp: 2/10/2013 9:57:42 PM Error: TypeError: Value not an object.: DT_attachKeybindingsToBrowser@resource://gre/modules/devtools/gDevTools.jsm:361 DT_addToolToWindows@resource://gre/modules/devtools/gDevTools.jsm:391 @resource://gre/modules/devtools/gDevTools.jsm:631 EventEmitter_emit@resource:///modules/devtools/EventEmitter.jsm:100 DT_registerTool@resource://gre/modules/devtools/gDevTools.jsm:79 TUI__startup@chrome://graphical-timeline/content/frontend/TimelineUI.jsm:75 init@resource://gre/modules/XPIProvider.jsm -> jar:file:///C:/Users/Girish%20Sharma/AppData/Roaming/Mozilla/Firefox/Profiles/vy8p218z.default/extensions/graphical-timeline-of-events@devtools.xpi!/bootstrap.js:132 @resource://gre/modules/XPIProvider.jsm -> jar:file:///C:/Users/Girish%20Sharma/AppData/Roaming/Mozilla/Firefox/Profiles/vy8p218z.default/extensions/graphical-timeline-of-events@devtools.xpi!/bootstrap.js:157 safeCall@resource://gre/modules/AddonManager.jsm:81 getAddonByID_safeCall@resource://gre/modules/AddonManager.jsm:1652 getAddonByID_getVisibleAddonForID@resource://gre/modules/XPIProvider.jsm:3267 getVisibleAddonForID_executeAsync@resource://gre/modules/XPIProvider.jsm -> resource://gre/modules/XPIProviderUtils.js:1391 AsyncAddonListCallback_handleCompletion@resource://gre/modules/XPIProvider.jsm -> resource://gre/modules/XPIProviderUtils.js:173 Source File: resource:///modules/devtools/EventEmitter.jsm Line: (null)
|
Assignee | |
Comment 1•11 years ago
|
||
We might want to uplift it ?
|
||
Updated•11 years ago
|
Attachment #712263 -
Flags: review?(paul) → review+
|
|
||
Updated•11 years ago
|
Whiteboard: [land-in-fx-team]
|
||
Updated•11 years ago
|
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
|
||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4c653c568ab6
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 22
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•