it appears we are running regular reftest on armv6 android builds instead of reftest small

RESOLVED FIXED

Status

Release Engineering
General
RESOLVED FIXED
6 years ago
2 months ago

People

(Reporter: jmaher, Assigned: kmoir)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

about 6 weeks ago we added reftestsmall as a type to the mobile automation.  This does not change the resolution to 1600x1200 so we can save time and potential breakage due to excessive reboots.

I was looking at logs and noticed that armv6 builds use 1600x1200 resolution instead of the default 1024x768.  We should start transitioning as many builds and branches as possible to use the lower resolution.
(Assignee)

Updated

6 years ago
Assignee: nobody → kmoir
(Assignee)

Comment 1

6 years ago
Created attachment 713033 [details] [diff] [review]
patch

jmaher: so you mean that we should enable reftests small for all the panda and android fennec builders on all branches?  If this is the case, I can remove more code than this patch includes to make our configs less confusing.
it requires some changes in the code, I can't remember which branch has it all, but all tests from that branch forward should be running reftestsmall.
(Assignee)

Updated

6 years ago
Attachment #713033 - Flags: feedback?(bugspam.Callek)
(Assignee)

Comment 3

6 years ago
ping Callek, do you have any feedback?
Comment on attachment 713033 [details] [diff] [review]
patch

Review of attachment 713033 [details] [diff] [review]:
-----------------------------------------------------------------

Without giving it a real review (as in check of added/removed builders) this looks like a good idea/patch. Sorry for the delay
Attachment #713033 - Flags: feedback?(bugspam.Callek) → feedback+
(Assignee)

Updated

6 years ago
Attachment #713033 - Flags: review?(armenzg)

Comment 5

6 years ago
Comment on attachment 713033 [details] [diff] [review]
patch

Review of attachment 713033 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozilla-tests/mobile_config.py
@@ -564,5 @@
> -    BRANCHES[branch]["platforms"]["android"]["panda_android"]["opt_unittest_suites"] = deepcopy(ANDROID_UNITTEST_DICT["opt_unittest_suites"])
> -    BRANCHES[branch]["platforms"]["android"]["tegra_android"]["opt_unittest_suites"] = deepcopy(ANDROID_UNITTEST_DICT["opt_unittest_suites"])
> -#-------------------------------------------------------------------------
> -# End Load reftests small for m-c based branches and exclude them for the rest
> -#-------------------------------------------------------------------------

As long as we are sure that the code is in place for mozilla-release as well this should be correct.
Attachment #713033 - Flags: review?(armenzg) → review+
(Assignee)

Updated

6 years ago
Attachment #713033 - Flags: checked-in+
In production
(Assignee)

Comment 7

6 years ago
verified on tbpl
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
Component: General Automation → General
Product: Release Engineering → Release Engineering
You need to log in before you can comment on or make changes to this bug.