840229 - it appears we are running regular reftest on armv6 android builds instead of reftest small

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

about 6 weeks ago we added reftestsmall as a type to the mobile automation.  This does not change the resolution to 1600x1200 so we can save time and potential breakage due to excessive reboots.

I was looking at logs and noticed that armv6 builds use 1600x1200 resolution instead of the default 1024x768.  We should start transitioning as many builds and branches as possible to use the lower resolution.

Comment 1

[Kim Moir [:kmoir] ET]

Attachment: patch

jmaher: so you mean that we should enable reftests small for all the panda and android fennec builders on all branches?  If this is the case, I can remove more code than this patch includes to make our configs less confusing.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

it requires some changes in the code, I can't remember which branch has it all, but all tests from that branch forward should be running reftestsmall.

Comment 3

[Kim Moir [:kmoir] ET]

ping Callek, do you have any feedback?

Comment 4

[Justin Wood (:Callek)]

Comment on attachment 713033 [details] [diff] [review]
patch

Review of attachment 713033 [details] [diff] [review]:
-----------------------------------------------------------------

Without giving it a real review (as in check of added/removed builders) this looks like a good idea/patch. Sorry for the delay

Comment 5

[Armen [:armenzg]]

Comment on attachment 713033 [details] [diff] [review]
patch

Review of attachment 713033 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozilla-tests/mobile_config.py
@@ -564,5 @@
> -    BRANCHES[branch]["platforms"]["android"]["panda_android"]["opt_unittest_suites"] = deepcopy(ANDROID_UNITTEST_DICT["opt_unittest_suites"])
> -    BRANCHES[branch]["platforms"]["android"]["tegra_android"]["opt_unittest_suites"] = deepcopy(ANDROID_UNITTEST_DICT["opt_unittest_suites"])
> -#-------------------------------------------------------------------------
> -# End Load reftests small for m-c based branches and exclude them for the rest
> -#-------------------------------------------------------------------------

As long as we are sure that the code is in place for mozilla-release as well this should be correct.

Comment 6

[John Hopkins (:jhopkins)]

In production

Comment 7

[Kim Moir [:kmoir] ET]

verified on tbpl