Closed Bug 840278 Opened 9 years ago Closed 9 years ago
Crypt demo broken on nightly (21)
The crypt demo starts to run OK, but after about 2-3 seconds it starts rendering basically without any textures. Sometimes it works ok. Useful STR seem to be: 1. Run firefox 2. Shift-control-k to bring up JS console 3. Load crypt from URL
Desperately could use a regression window on this. I suspect in the past few weeks.
I just bisected this to: Last good nightly: 2013-01-27 First bad nightly: 2013-01-28 Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f18b12139151&tochange=80fed51ae074
In that range: Benoit Jacob — Bug 832576 - Fix perf regression in WebGL uniform setters - r=jgilbert Benoit Jacob — Bug 827170 - Clamp intermediate surface's framebuffer dimensions to what is supported by the GL - r=BenWa Without this, we have assertion failures as we fail to create our textures and subsequently we have incomplete framebuffers. The present patch is a short-term compromise: to avoid asserting, we just clamp texture sizes. That can result in fuzzy rendering. Ideally (with some suitable tiling) we wouldn't have to do that.
Awesome, thanks Alice!
This patch seems to fix the site. The problem was that object initializers with sparse indexed properties did not have type information indicating the presence of the sparse indexes, so that when we compiled 'in' operations (or other indexed operations) on those objects the compiled code could ignore the sparse indexes and behave incorrectly.
Attachment #713656 - Flags: review?(jdemooij)
Attachment #713656 - Flags: review?(jdemooij) → review+
http://crypt-webgl.unigine.com/ works fine in 32.0a1 (2014-05-18), win 7 x64
You need to log in before you can comment on or make changes to this bug.