840309 - mozharness XP xpcshell on Cedar is perma-orange/purple

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Aki Sasaki (not active)]

Last good revision: 08388ff940df
First bad revision: 784b9beebe90

Symptoms:

12:24:18    ERROR - There was an error while copying c:\talos-slave\test\build\tests\bin\components to c:\talos-slave\test\build\application\firefox\components!
12:24:18    ERROR - Traceback (most recent call last):
12:24:18    ERROR - 
12:24:18    ERROR -   File "c:\talos-slave\test\scripts\mozharness\base\script.py", line 257, in copytree
12:24:18    ERROR -     shutil.copy2(abs_src_f, abs_dest_f)
12:24:18    ERROR - 
12:24:18    ERROR -   File "c:\mozilla-build\python27\lib\shutil.py", line 128, in copy2
12:24:18    ERROR -     copyfile(src, dst)
12:24:18    ERROR - 
12:24:18    ERROR -   File "c:\mozilla-build\python27\lib\shutil.py", line 83, in copyfile
12:24:18    ERROR -     with open(dst, 'wb') as fdst:
12:24:18    ERROR - 
12:24:18    ERROR - IOError: [Errno 2] No such file or directory: 'c:\\talos-slave\\test\\build\\application\\firefox\\components\\httpd.js'

Then httpd.js related test failures.

Comment 1

[Aki Sasaki (not active)]

So the issue here is this line:

13:58:28     INFO - copying tree: c:\talos-slave\test\build\tests\bin\components to c:\talos-slave\test\build\application\firefox\components

It looks like build/application/firefox/components is not a dir.
mkdir -p'ing that directory removes the error on talos-r3-fed-001.

Going to patch that, and also the buildprops-output-as-non-json issue as well, since that bit me while debugging here.

Comment 2

[Aki Sasaki (not active)]

Attachment: (mozharness) [needs testing] fix win xpcshell, pep8-ify mozharness/base/script, output buildprops.json as json

Comment 3

[Aki Sasaki (not active)]

Attachment: (mozharness) fix win xpcshell, pep8-ify mozharness/base/script, output buildprops.json as json

The mozharness/base/script.py changes are basically

* pep8,
* removed a partial bug number comment, and
* don't do the overwrite/no_overwrite logic if dest doesn't exist in copytree().

The mozharness/mozilla/buildbot.py change is to dump buildprops.json in json format rather than pprint format, so we can replicate more easily.

Comment 4

[Mike Hommey [:glandium]]

(In reply to Aki Sasaki [:aki] from comment #1)
> So the issue here is this line:
> 
> 13:58:28     INFO - copying tree:
> c:\talos-slave\test\build\tests\bin\components to
> c:\talos-slave\test\build\application\firefox\components

Why does it do that, btw?

Comment 5

[Rail Aliiev [:rail]]

Comment on attachment 712790 [details] [diff] [review]
(mozharness) fix win xpcshell, pep8-ify mozharness/base/script, output buildprops.json as json

lgtm

Comment 6

[Aki Sasaki (not active)]

(In reply to Mike Hommey [:glandium] from comment #4)
> (In reply to Aki Sasaki [:aki] from comment #1)
> > So the issue here is this line:
> > 
> > 13:58:28     INFO - copying tree:
> > c:\talos-slave\test\build\tests\bin\components to
> > c:\talos-slave\test\build\application\firefox\components
> 
> Why does it do that, btw?

Not sure, this is just part of the xpcshell test aiui.

Comment 7

[Aki Sasaki (not active)]

Comment on attachment 712790 [details] [diff] [review]
(mozharness) fix win xpcshell, pep8-ify mozharness/base/script, output buildprops.json as json

http://hg.mozilla.org/build/mozharness/rev/f113fd03dbe4
Thanks Rail!

Comment 8

[Aki Sasaki (not active)]

I see green.