840317 - media queries in scoped style sheets not re-evaluated

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Cameron McCormack (:heycam)]

Attachment: test

@media rules in scoped style sheets don't seem to be re-evaluated properly.  Open the attached test, resize the window and see how the background colour does not change.

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

probably need to fix nsStyleSet::MediumFeaturesChanged

Comment 2

[Cameron McCormack (:heycam)]

Looks like it.  (I see I need to update SizeOfIncludingThis too.)

Comment 3

[Cameron McCormack (:heycam)]

Attachment: patch

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 712690 [details] [diff] [review]
patch

May as well also toss in nsTArray::SizeOfExcludingThis to include the size of the array's buffer too.

r=dbaron

Comment 5

[Cameron McCormack (:heycam)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b8c19a26a1d2

Comment 6

[Daniel Holbert [:dholbert]]

This needed a followup to fix a build warning (treated as error), for a signed loop variable being compared to an unsigned value (Length()):
 https://hg.mozilla.org/integration/mozilla-inbound/rev/6d92250d9e52

Comment 7

[Cameron McCormack (:heycam)]

Thanks Daniel.

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b8c19a26a1d2
https://hg.mozilla.org/mozilla-central/rev/6d92250d9e52