Closed
Bug 840346
Opened 10 years ago
Closed 10 years ago
[Holo] Flat UI
Categories
(Firefox for Android Graveyard :: Theme and Visual Design, defect)
Tracking
(relnote-firefox 21+)
RESOLVED
FIXED
Firefox 21
Tracking | Status | |
---|---|---|
relnote-firefox | --- | 21+ |
People
(Reporter: sriram, Unassigned)
Details
Attachments
(6 files, 1 obsolete file)
87.31 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
11.87 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
15.99 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
11.62 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
7.19 KB,
patch
|
cwiiis
:
review+
|
Details | Diff | Splinter Review |
4.24 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
Remove all textures, use solid colors for all the backgrounds.
Reporter | ||
Comment 1•10 years ago
|
||
This removes a whole bunch of stuff in Java, replaces few resources for the rounded rectangle. Only colors are used everywhere.
Attachment #712719 -
Flags: review?(mark.finkle)
Reporter | ||
Comment 2•10 years ago
|
||
Ideally its better to combine both the colors into and paint it (earlier one was a texture and the other a color). But I couldn't find a proper filter. So, this just replaces texture with a color. And few renaming for my OCD. :D
Attachment #712721 -
Flags: review?(mark.finkle)
Reporter | ||
Comment 3•10 years ago
|
||
These sync icons were there for no reason. Purged completely.
Attachment #712722 -
Flags: review?(mark.finkle)
Reporter | ||
Comment 4•10 years ago
|
||
And flat UI for about:pages. This removes the images and replaces them with colors.
Attachment #712723 -
Flags: review?(mark.finkle)
Reporter | ||
Comment 5•10 years ago
|
||
Adding kats to remove the "abouthome_bg" texture used by LayerView, and replaced it with R.color.background_normal.
Reporter | ||
Comment 6•10 years ago
|
||
This fixes the color-filter problem with persona. Now that we are using solid colors (yaay!), we can combine the solid color (like the grey), with a dominant color using a color filter. This when drawn, it's drawn as one single paint operation rather than two. That's a win! May be, if we find the color filter to be slower, we can combine the two colors ourselves and set it as a single color to paint. But I don't think color filter is slower. Android does it for us for free :D Also, I find the about:home to scroll a bit faster with personas -- with this change.
Attachment #712721 -
Attachment is obsolete: true
Attachment #712721 -
Flags: review?(mark.finkle)
Attachment #713020 -
Flags: review?(mark.finkle)
Comment 7•10 years ago
|
||
Comment on attachment 712719 [details] [diff] [review] Part 1: Flat URL bar I can't wait to see this in the app. The code cleanup alone is really nice. You might want to double check you removed all the files we no longer need.
Attachment #712719 -
Flags: review?(mark.finkle) → review+
Comment 8•10 years ago
|
||
Comment on attachment 712722 [details] [diff] [review] Part 3: Unwanted icons Yay! for more cleanup
Attachment #712722 -
Flags: review?(mark.finkle) → review+
Comment 9•10 years ago
|
||
Comment on attachment 712723 [details] [diff] [review] Part 4: Flat about: pages I am slightly worried that add-ons might be using these background images. We can see if anyone reports problems with add-on about: pages.
Attachment #712723 -
Flags: review?(mark.finkle) → review+
Updated•10 years ago
|
Attachment #713020 -
Flags: review?(mark.finkle) → review+
Reporter | ||
Comment 10•10 years ago
|
||
Inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/700ef0823d91 https://hg.mozilla.org/integration/mozilla-inbound/rev/eb2e980741b7 https://hg.mozilla.org/integration/mozilla-inbound/rev/2813cfcfd1c1 https://hg.mozilla.org/integration/mozilla-inbound/rev/6f28814befb7
Comment 11•10 years ago
|
||
Here's a patch that gets rid of the background layer and replaces it with a solid Color.MAGENTA. You can replace that color with whatever you like, or pull it from a resource file or whatever. I'm leaving it without a review request for now since I don't know if you want to make more changes on this, but if you want it reviewed Cwiiis would probably be the best reviewer for this patch.
Reporter | ||
Comment 12•10 years ago
|
||
Comment on attachment 713606 [details] [diff] [review] Part x: Get rid of the background tile layer I would like to replace Color.MAGENTA with a | mView.getContext().getResources().getColor(R.color.background_normal) | before pushing.
Attachment #713606 -
Flags: review?(chrislord.net)
Reporter | ||
Updated•10 years ago
|
Whiteboard: [leave open]
Comment 13•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/700ef0823d91 https://hg.mozilla.org/mozilla-central/rev/eb2e980741b7 https://hg.mozilla.org/mozilla-central/rev/2813cfcfd1c1 https://hg.mozilla.org/mozilla-central/rev/6f28814befb7
Comment 14•10 years ago
|
||
Comment on attachment 713606 [details] [diff] [review] Part x: Get rid of the background tile layer Review of attachment 713606 [details] [diff] [review]: ----------------------------------------------------------------- LGTM, assuming the colour will be changed. ::: mobile/android/base/gfx/LayerRenderer.java @@ +536,5 @@ > > + // Clear the page area to the page background colour. > + setScissorRect(); > + clear(mBackgroundColor); > + GLES20.glDisable(GLES20.GL_SCISSOR_TEST); I'd be interested to know if a clear+scissor is faster or slower than a texture draw... Are there any talos results? Specifically, tpan.
Attachment #713606 -
Flags: review?(chrislord.net) → review+
Reporter | ||
Comment 15•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a119a9b9d390
Reporter | ||
Comment 16•10 years ago
|
||
Zarro textures found!
Attachment #713972 -
Flags: review?(mark.finkle)
Updated•10 years ago
|
Attachment #713972 -
Flags: review?(mark.finkle) → review+
Reporter | ||
Comment 17•10 years ago
|
||
We are so clean! https://hg.mozilla.org/integration/mozilla-inbound/rev/e36402a56225
Whiteboard: [leave open]
Comment 18•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a119a9b9d390 https://hg.mozilla.org/mozilla-central/rev/e36402a56225
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 21
Reporter | ||
Updated•10 years ago
|
relnote-firefox:
--- → ?
Updated•10 years ago
|
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•