84036 - All accounts showing up in the filterlist, even those that doesn't support filtering

Status: VERIFIED FIXED

(MailNews Core :: Filters, defect, P3)

Description

[Skewer]

Procedure: I have one mail account and two news accounts (+ local folders). I
can create filters for my mail just fine, but when I pull down the list and try
to create a new filter for either newsgroup account, nothing happens. Worse, the
OK button stops working. Clicking these buttons fills my JS console up with
messages like this:

Error: uncaught exception: [Exception... "Component returned failure code:
0x80004005 (NS_ERROR_FAILURE) [nsIRDFResource.GetDelegate]"  nsresult:
"0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame ::
chrome://messenger/content/FilterListDialog.js :: currentFilterList :: line 140"
 data: no]

Build: 2001060409 Win98

Comment 1

[Skewer]

PC/Win98 (D'oh.)
4xp.

Comment 2

[laurel]

We don't even support news filters in 6.0 or current release ...
The commercial builds don't even show the news accounts anywhere in the filter
ui: Not in the main filter dialog or filter rules as a target folder possibility.  

So I'm not sure how you're even getting to the news accounts. Unless it's some
mutant profile from a long time ago? Unless it's a mozilla only thing.

Comment 3

[laurel]

Even if I migrate a 4.x profile with news filters, we still don't show news
accounts in filter ui.  

Comment 4

[Skewer]

When I pull down the list in the build mentioned previously, both my news
accounts are there, and I've created both in this build (due to an accidental
deleting of a data file in my Users50 directory). If it's an old profile, they
should be stripped on load anyway.

Why wouldn't we have news filters, though? That's one of the major
functionalities I expect from a fully-featured newsreader, and the same is true
for all other Netscape users. Outlook Express supports news filters, so there is
competition involved, too. If there's a bug regarding news filter support, lead
me to it so I can vote for it - this is enough to change a customer's decision
between NS and IE.

Comment 5

[laurel]

News filters: see bug 17483, 16913.

Comment 6

[laurel]

I just tried this with jun5 trunk build -- news accts are appearing in filters.
 So this is trunk only, not happening in the 0.9.1 branch.  I don't know when
this started in the trunk -- I don't recall seeing it last week, but will go
back and double-check.

Comment 7

[laurel]

FYI -- with the may31 trunk commericial build (the day before we branched), I
cannot reproduce the news accounts showing in the filters scope dialog.  This
news acct problem was introduced in the trunk after may31.

Comment 8

[laurel]

adding nsbeta1 keyword since we need to correct this (so as not to see News
accounts in filter ui) on the trunk before RTM.

Comment 9

[Håkan Waara]

Laurel, do you mean that the newsaccounts shouldn't appear or that
news-filtering should magically work?

Comment 10

[laurel]

News accounts should not appear.  

Comment 11

[Håkan Waara]

Changing summary

Comment 12

[laurel]

removing 4xp keyword

Comment 13

[Håkan Waara]

I debugged this this evening and figured out the following:

The code in nsAccountManagerDS.cpp to decide whether an account supports 
filtering (the SupportsFilters rule) is not getting called at all when called 
from FilterListDialog.xul

I'm trying to understand why, although I don't know much about RDF/templates so 
I may have missed something obvious.

Comment 14

[(not reading, please use [e-mail] instead)]

fall out from bug #70258.

it's a simple fix, I'll attach the patch. 

we should get this into 0.9.1 and the trunk.

Comment 15

[(not reading, please use [e-mail] instead)]

Attachment: the fix

Comment 16

[(not reading, please use [e-mail] instead)]

fall out from #79258, not #70258

Comment 17

[scottputterman]

I don't think this is an 0.9.1 stopper (if I'm reading this right, choosing an
news filter prevents the dialog from being closed and that's the only bad thing
that happens). Maybe 0.9.2

Comment 18

[(not reading, please use [e-mail] instead)]

0.9.2 is fine with me.

this has sr=bienvenu

I'll get it in the trunk.

Comment 19

[Håkan Waara]

r=hwaara with a fair amount of sadness (I wanted to investigate and fix this bug)

Comment 20

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to the trunk.
(on behalf of drivers)

Comment 21

[(not reading, please use [e-mail] instead)]

fixed.

Comment 22

[Skewer]

Verified 2001060804 Win98.

Comment 23

[laurel]

I need to check this on the trunk on all platforms, please don't mark verified.

Comment 24

[laurel]

setting back to FIXED

Comment 25

[laurel]

New accounts no longer showing in "filters for:"/scope dropdown list.
OK using june14 commercial trunk builds, win98, mac OS 9.0, linux rh6.2