840415 - (gmock) Add GMock support to GTest

Status: RESOLVED FIXED

(Testing :: General, defect)

Comment 1

[Benoit Girard (:BenWa)]

Attachment: gmock + SanityTest

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 712811 [details] [diff] [review]
gmock + SanityTest

Review of attachment 712811 [details] [diff] [review]:
-----------------------------------------------------------------

Good stuff!

::: testing/gtest/Makefile.in
@@ +72,5 @@
> +  gmock/include/gmock/gmock-spec-builders.h \
> +  gmock/include/gmock/gmock.h \
> +  $(NULL)
> +
> +# gmock also includes internal interfaces in it's public header

nit: its

::: toolkit/content/license.html
@@ +1333,5 @@
>  
>      <p>This license applies to files in the directories
>      <span class="path">toolkit/crashreporter/google-breakpad/</span>,
>      <span class="path">testing/gtest/gtest</span>,
> +    <span class="path">testing/gtest/gmock</span>,

Not needed.

Comment 3

[Benoit Girard (:BenWa)]

Attachment: gmock + SanityTest final, r=ted

Comment 4

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e62fcee5ce5e

Comment 5

[Gregory Szorc [:gps]]

https://hg.mozilla.org/mozilla-central/rev/e62fcee5ce5e