840469 - Make animateMotion-mpath-pathLength-1.svg render in a failure state, when its script and/or animations don't run

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Jonathan Watt [:jwatt]]

After bug 839865 landed, we got a bunch of intermittent orange in animateMotion-mpath-pathLength-1.svg. I couldn't reproduce the orange locally until I changed the test so that it's initial state is not also the pass state. This patch makes that change permanent to avoid this problem in future.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Daniel Holbert [:dholbert]]

[clarifying summary, so that a wandering sheriff doesn't accidentally mark this as a randomorange bug]

Comment 3

[Daniel Holbert [:dholbert]]

Comment on attachment 712866 [details] [diff] [review]
patch

r=me

Bonus points if you want to offset the times by 100s, as we've started doing elsewhere, too.  (to avoid immediate-animation on test load, which sometimes blocks MozReftestInvalidate from being fired until all of the animations have completed.)

So that'd be adding begin="100s" to both animateMotion elements, and s/0.5/100.5/ in the setTimeAndSnapshot call.

That doesn't have to happen here if you'd prefer to keep this simple though.

Comment 4

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3f3b3b3f1797

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3f3b3b3f1797