840556 - shorten spidermonkey build dir names

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[[e-mail] (:bhearsum)]

Specifically, it looks like some b2g builds (device ones were what I saw), fuzzing, and spidermonkey aren't. Suspiciously, all of these things use ScriptFactory. Might be other jobs too, not sure.

Comment 1

[[e-mail] (:bhearsum)]

OK, so fuzzing and nanojit definitely aren't using normalizeName (https://github.com/mozilla/build-buildbotcustom/blob/041c7f18a8dd9bd7fb894b6efbb8dcd417b92578/misc.py#L2276, https://github.com/mozilla/build-buildbotcustom/blob/041c7f18a8dd9bd7fb894b6efbb8dcd417b92578/misc.py#L2324) -- but that's fine because they're nothing like the builds that we were trying to sync up.

Spidermonkey is using it, but has a max higher than the min (https://github.com/mozilla/build-buildbotcustom/blob/041c7f18a8dd9bd7fb894b6efbb8dcd417b92578/misc.py#L2428). We should fix that because those builds are run on various branches and could hit max dir/path length problems.

The B2G ones are surprising to me. AFAIK the code that creates them is here: https://github.com/mozilla/build-buildbotcustom/blob/041c7f18a8dd9bd7fb894b6efbb8dcd417b92578/misc.py#L998 -- and those are both using normalizeName without overriding min or max.

Comment 2

[[e-mail] (:bhearsum)]

Attachment: make spidermonkey consistent

Here's a patch for the Spidermonkey part. Still investigating b2g.

Comment 3

[[e-mail] (:bhearsum)]

Oh, and because of the problems with changing slave build dirs in a reconfig, should probably plan to do a graceful restart when landing this.

Comment 4

[[e-mail] (:bhearsum)]

oooookay. Now I'm seeing all of the b2g jobs using padded directories -- which makes sense. I was probably looking at older jobs than I thought I was earlier. So to recap: the only thing to do here is adjust the spidermonkey names.

Comment 5

[[e-mail] (:bhearsum)]

I see this in a build I just triggered:
hg clone http://hg.mozilla.org/build/tools scripts
 in dir /builds/slave/m-in_l64-d_sm-warnaserrdebug-0/. (timeout 1320 secs)