Closed
Bug 840577
Opened 12 years ago
Closed 12 years ago
Fix ANGLE cross compilation on case sensitive OSes
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: jacek, Assigned: jacek)
Details
Attachments
(1 file)
|
1.50 KB,
patch
|
bjacob
:
review+
|
Details | Diff | Splinter Review |
The patch is really trivial. It's waiting for review in upstream for over two weeks already (from my past eperience with similar fixes in ANGLE, another few weeks would be a good ETA for getting it reviewed :-/):
https://codereview.appspot.com/7193060/
It's currently the only thing blocking m-c compilation with mingw, so perhaps we could take a local patch and drop it on future ANGLE update.
Attachment #712957 -
Flags: review?(bjacob)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 712957 [details] [diff] [review]
fix
Review of attachment 712957 [details] [diff] [review]:
-----------------------------------------------------------------
r+++++++++++++++++++++++++
Attachment #712957 -
Flags: review?(bjacob) → review+
|
|
||
Comment 2•12 years ago
|
||
Note: please update gfx/angle/README.mozilla too.
|
Assignee | |
Comment 3•12 years ago
|
||
Thanks for quick review! Pushed with README.mozilla updated:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bc70cddbac4a
|
||
Comment 4•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
|
|
Assignee | |
Comment 5•12 years ago
|
||
I relanded it after angle update. Upstream keeps ignoring my patch :/
https://hg.mozilla.org/integration/mozilla-inbound/rev/d675e66995b0
Also includes a trivial Makefile GCC bustage fix.
|
||
Comment 6•12 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•