840601 - Clear saved reader mode page in tab destroy

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Brian Nicholson (:bnicholson)]

Since we keep the same tab object when zombifying tabs, I think we'll want to clear out the saved reader mode article.

Comment 1

[Brian Nicholson (:bnicholson)]

Attachment: Clear saved reader mode page in tab destroy

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 712980 [details] [diff] [review]
Clear saved reader mode page in tab destroy

Review of attachment 712980 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch, thanks!

Comment 3

[Brian Nicholson (:bnicholson)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a73456511f41

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a73456511f41

Comment 5

[Brian Nicholson (:bnicholson)]

Comment on attachment 712980 [details] [diff] [review]
Clear saved reader mode page in tab destroy

[Approval Request Comment]
Bug caused by (feature/regressing bug #): none
User impact if declined: higher memory footprint when tabs are zombified
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): very low risk
String or UUID changes made by this patch: none

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 712980 [details] [diff] [review]
Clear saved reader mode page in tab destroy

One liner, approving for uplift.

Comment 7

[Brian Nicholson (:bnicholson)]

https://hg.mozilla.org/releases/mozilla-beta/rev/2b22e21e7339