Closed
Bug 840626
Opened 12 years ago
Closed 12 years ago
dom/devicestorage/test/test_watch.html always times out (except apparently sometimes on Tinderbox?)
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bzbarsky, Assigned: dougt)
Details
Attachments
(1 file)
949 bytes,
patch
|
bzbarsky
:
review+
bajaj
:
approval-mozilla-b2g18+
|
Details | Diff | Splinter Review |
Steps to reproduce:
make TEST_PATH=dom/devicestorage/test/ -C ../obj-firefox mochitest-plain
Run the tests.
Expected results: tests pass
Actual results: dom/devicestorage/test/test_watch.html times out.
![]() |
Reporter | |
Comment 1•12 years ago
|
||
Hmm. This works if I run the tests from dom/devicestorage/ as opposed to dom/devicestorage/test
Is this test somehow depending on dom/devicestorage/ipc/test_ipc.html ?
Assignee | ||
Comment 2•12 years ago
|
||
Right, if you run from dom/devicestorage/ we will run the device storage tests in ipc.
![]() |
Reporter | |
Comment 3•12 years ago
|
||
If I run from dom/devicestorage we'll run them twice: once in ipc and once normally. The normal runs pass for me in a clean build, but only if they happen after the ipc runs.
Assignee | ||
Comment 4•12 years ago
|
||
The FileUpdateDispatcher converts file-watcher-notify observer events to file-watcher-update events. This is used to be able to broadcast events from one child to another child in B2G. (f.e., if one child decides to add a file, we want to be able to able to send a onchange notifications to every other child watching that device storage object). In the non-ipc case, we were not ensuring that this object was created. The result was that test_watch.html in the non-ipc case would hang until something wrote/deleted a file using device storage.
Attachment #713050 -
Flags: review?(bzbarsky)
![]() |
Reporter | |
Comment 5•12 years ago
|
||
Comment on attachment 713050 [details] [diff] [review]
patch v.1
Please add a comment that indicates that this GetSingleton() might be the only thing that creates the object. Maybe just put most of comment 4 in your checkin comment?
Attachment #713050 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 6•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 7•12 years ago
|
||
Comment on attachment 713050 [details] [diff] [review]
patch v.1
[Approval Request Comment]
The Gaia e-mail app unit tests would like to be able to use DeviceStorage change notifications in its unit tests to assert on events triggering which run against mozilla-b2g18 builds for realism. This very minor fix (which made unit tests work!) allows DeviceStorage onchange notifications to work in a non-IPC contexts (Which is how the tests run).
Since the fix is just triggering the creation of a singleton and that already happens in the primary B2G case, this patch should not impact primary use cases.
Attachment #713050 -
Flags: approval-mozilla-b2g18?
Comment 8•12 years ago
|
||
Comment on attachment 713050 [details] [diff] [review]
patch v.1
Impacts Debug only builds,approving for uplift
Attachment #713050 -
Flags: approval-mozilla-b2g18? → approval-mozilla-b2g18+
Comment 9•12 years ago
|
||
landed on mozilla-b2g18:
https://hg.mozilla.org/releases/mozilla-b2g18/rev/e4e74a2d5189
Thank you for the prompt approval!
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•