Closed Bug 840684 Opened 9 years ago Closed 8 years ago

Source map the location of frames in the RDP

Categories

(DevTools :: Debugger, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 26

People

(Reporter: fitzgen, Assigned: fitzgen)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

The locations reported by frames over the RDP should be source mapped so that you see the original sources and not the generated sources.
Assignee: nobody → nfitzgerald
marking P2 since it has an assignee.
Priority: -- → P2
This is implemented in bug 860035, which is just waiting on final review from Jim. We can close this as soon as that lands.
Depends on: 860035
Is the attached test in this bug still useful, or is it subsumed in the patch for bug 860035?
browser_dbg_source_maps-03.js tests the first frame via checking the caret position, but there isn't an explicit test for it. I guess we can leave this open, then add the test for more coverage, and close the bug after that.
Adds two source mapping related tests (for functionality we already have, but isn't well tested):

1. The frame included in paused packets

2. The list of frames returned from "frames" requests

https://tbpl.mozilla.org/?tree=Try&rev=8169f5bbd5fc
Attachment #713169 - Attachment is obsolete: true
Attachment #789967 - Flags: review?(vporof)
Comment on attachment 789967 [details] [diff] [review]
bug-840684-source-map-frames.patch

Review of attachment 789967 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #789967 - Flags: review?(vporof) → review+
Whiteboard: [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/15aaeae89597
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/15aaeae89597
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 26
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.