840703 - Adblock settings missbehaving

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Add-on Manager, defect)

Description

[Michael Monreal [:micmon]]

Pressing the "filter subscription" list button in Adblock settings does not show the list most of the time, it just darkens the screen.

In very rare cases (one in 20 maybe) the llist is actually displayed. Pressing one item selects the item above it, which will not be the value shown in the list button. However, there is now way to actually save this, pressing "back" reverts the value to "Easylist".

Comment 1

[Aaron Train [:aaronmt]]

I'm able to reproduce this on all channels.

Comment 2

[Wesley Johnston (:wesj)]

Attachment: Patch

I am not entirely sure what's going wrong here. AFAICT, Adblock ships a control that looks like:

  <setting type="control" title="&subscriptions.tab.label;">
    <menulist id="adblockplus-subscription-list"/>
  </setting>

and fills in the list at some point, so I think this may be a race. I also realized we really don't need this binding for menulist anymore though. SelectHelper already intercepts clicks for us, and the rest of the code in there seemed to be for hiding the gtk popup, which we no longer show anyway?

Removing that binding seems to fix the problem for me. I wonder if our binding and click handling was interfering with adblock creating the filter list?

Comment 3

[Matt Brubeck (:mbrubeck)]

Comment on attachment 716762 [details] [diff] [review]
Patch

Looks good to me.  I think the click-handling here was only needed for <menulist> elements in browser chrome (which /mobile/android no longer uses).  For in-content UI like the add-on manager, SelectHelper's event handling is all we need.

Comment 4

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6271f9482ede

Comment 5

[Gregory Szorc [:gps]]

https://hg.mozilla.org/mozilla-central/rev/6271f9482ede

Comment 6

[Andreea Pod]

I am not able to verify this issue, due to Bug 847002

Comment 7

[Scoobidiver (away)]

(In reply to Andreea Pod from comment #6)
> I am not able to verify this issue, due to Bug 847002
You can in builds between February 25th and 28th.

Comment 8

[Andreea Pod]

Verified fixed on:
-build: Firefox for Android 22.0a1 (2013-02-27)
-device: Samsung Galaxy Nexus
-OS: Android 4.1.1