With the changes in bug 752946 it is possible to create a new bug (either via RPC or URL hijacking) with a milestone that is inactive. This shouldn't be allowed.
Created attachment 713221 [details] [diff] [review]
I've request the blocking on this bug on the same basis as the bug that created the problem.
Comment on attachment 713221 [details] [diff] [review]
I think the problem you describe affects versions and components too. IMO, the right fix is to write:
my $old_foo = blessed($invocant) ? $invocant->foo : '';
This way, the first part of
if ($object->name ne $old_foo && !$object->is_active)
will always be false for new bugs (a component, version or milestone cannot be '') and we will always call !$object->is_active.
So please fix this issue for versions and components too.
This is less problematic for new bugs, because the UI doesn't list inactive values. So unless you hack the URL directly, honest users are not affected by this issue. But I'm fine to take it for 4.2.5 anyway as the fix in bug 752946 is incomplete.
Created attachment 713735 [details] [diff] [review]
Comment on attachment 713735 [details] [diff] [review]
No need to write : '' on its own line. On checkin, it should be moved on the same line as foo ? bar. r=LpSolit
Committing to: bzr+ssh://firstname.lastname@example.org/bugzilla/trunk/
Committed revision 8577.
Committing to: bzr+ssh://email@example.com/bugzilla/4.4/
Committed revision 8518.
Committing to: bzr+ssh://firstname.lastname@example.org/bugzilla/4.2/
Committed revision 8187.