840868 - [Overdraw] Window background should be reset

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sriram Ramasubramanian [:sriram]]

It's good to set window background in XML, so that Android makes it feel like the app has started loading when launching from launcher. It's like the background on a webpage. Like in a webpage, its good to have the background for the entire page, and leave the individual elements transparent. However, we cannot do that as we have 3-4 different layers in the content section of our gecko-app. Hence the windowBackground is pretty useless once the app has loaded. This can be removed reducing the overdraw.

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

This reduces overdraw in about:home section. I could see the about:home go from all red to less red in background area. WIN! :D

Comment 2

[Lucas Rocha (:lucasr)]

Comment on attachment 713282 [details] [diff] [review]
Patch

Review of attachment 713282 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/GeckoApp.java
@@ +2069,5 @@
>  
>          if (!mInitialized && hasFocus)
>              initialize();
> +
> +        getWindow().setBackgroundDrawable(null);

Maybe it makes more sense to just do it once after the initialize() call (inside the 'if')?

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 713282 [details] [diff] [review]
Patch

I agree with Lucas. It seems like something we should only call one time. Moving it into the "if" block would make that happen.

r+, but move into the if block

Comment 4

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2440035e8590

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2440035e8590