840874 - Get Skia backend working on Qt port

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Oleg Romashin (:romaxa)]

Attachment: Qt Azure skia content render

Here is basic patch which fix some build issues and should work on top of tng branch

Comment 1

[Oleg Romashin (:romaxa)]

Attachment: Qt Azure skia content render

Comment 2

[George Wright (:gw280) (needinfo me!)]

Comment on attachment 752171 [details] [diff] [review]
Qt Azure skia content render

Review of attachment 752171 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/gfxQtPlatform.cpp
@@ +632,5 @@
> +    NS_ASSERTION(aFont->GetType() == gfxFont::FONT_TYPE_FT2, "Expecting Freetype font");
> +    nativeFont.mType = NATIVE_FONT_SKIA_FONT_FACE;
> +    nativeFont.mFont = static_cast<gfxFT2FontBase*>(aFont)->GetFontOptions();
> +    return Factory::CreateScaledFontForNativeFont(nativeFont, aFont->GetAdjustedSize());
> +}

Can we share this method with gfxPlatformGtk? I would like to avoid code duplication if possible.

Comment 3

[Oleg Romashin (:romaxa)]

Attachment: Qt Azure skia content render, minor refactor for shared functionality

Comment 4

[George Wright (:gw280) (needinfo me!)]

Comment on attachment 752206 [details] [diff] [review]
Qt Azure skia content render, minor refactor for shared functionality

Review of attachment 752206 [details] [diff] [review]:
-----------------------------------------------------------------

In principle I'm ok with this, but you should probably flag Bas for review as well. Also, you appear to be missing the hunk that modifies Factory.cpp?

Comment 5

[Bas Schouten (:bas.schouten)]

Hrm, we should really get my font refactoring from the Moz2D repository onto m-c :s, also, as gw280 says?

Comment 6

[Oleg Romashin (:romaxa)]

Attachment: Qt Azure skia content render, minor refactor for shared functionality

Comment 7

[Oleg Romashin (:romaxa)]

Attachment: Qt Azure skia content render, minor refactor for shared functionalityattachment.cgiid=8363381

Comment 8

[Oleg Romashin (:romaxa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/af39c4df306f

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/af39c4df306f

Comment 10

[George Wright (:gw280) (needinfo me!)]

Comment on attachment 8364107 [details] [diff] [review]
Qt Azure skia content render, minor refactor for shared functionalityattachment.cgiid=8363381

Clearing review flag as Bas already r+d it