Get Skia backend working on Qt port

RESOLVED FIXED in mozilla29

Status

()

Core
Graphics
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: romaxa, Assigned: romaxa)

Tracking

unspecified
mozilla29
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 4 obsolete attachments)

(Assignee)

Description

5 years ago
Created attachment 713287 [details] [diff] [review]
Qt Azure skia content render

Here is basic patch which fix some build issues and should work on top of tng branch
(Assignee)

Comment 1

5 years ago
Created attachment 752171 [details] [diff] [review]
Qt Azure skia content render
Attachment #713287 - Attachment is obsolete: true
Attachment #752171 - Flags: review?(gwright)
Comment on attachment 752171 [details] [diff] [review]
Qt Azure skia content render

Review of attachment 752171 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/gfxQtPlatform.cpp
@@ +632,5 @@
> +    NS_ASSERTION(aFont->GetType() == gfxFont::FONT_TYPE_FT2, "Expecting Freetype font");
> +    nativeFont.mType = NATIVE_FONT_SKIA_FONT_FACE;
> +    nativeFont.mFont = static_cast<gfxFT2FontBase*>(aFont)->GetFontOptions();
> +    return Factory::CreateScaledFontForNativeFont(nativeFont, aFont->GetAdjustedSize());
> +}

Can we share this method with gfxPlatformGtk? I would like to avoid code duplication if possible.
(Assignee)

Comment 3

5 years ago
Created attachment 752206 [details] [diff] [review]
Qt Azure skia content render, minor refactor for shared functionality
Attachment #752171 - Attachment is obsolete: true
Attachment #752206 - Flags: review?(gwright)
Attachment #752171 - Flags: review?(gwright)
Comment on attachment 752206 [details] [diff] [review]
Qt Azure skia content render, minor refactor for shared functionality

Review of attachment 752206 [details] [diff] [review]:
-----------------------------------------------------------------

In principle I'm ok with this, but you should probably flag Bas for review as well. Also, you appear to be missing the hunk that modifies Factory.cpp?
Attachment #752206 - Flags: review?(gwright)
Attachment #752206 - Flags: review?(bas)
Attachment #752206 - Flags: review+
Hrm, we should really get my font refactoring from the Moz2D repository onto m-c :s, also, as gw280 says?
(Assignee)

Comment 6

4 years ago
Created attachment 8363381 [details] [diff] [review]
Qt Azure skia content render, minor refactor for shared functionality
Attachment #752206 - Attachment is obsolete: true
Attachment #752206 - Flags: review?(bas)
Attachment #8363381 - Flags: review?(bas)
(Assignee)

Comment 7

4 years ago
Created attachment 8364107 [details] [diff] [review]
Qt Azure skia content render, minor refactor for shared functionalityattachment.cgiid=8363381
Attachment #8363381 - Attachment is obsolete: true
Attachment #8363381 - Flags: review?(bas)
Attachment #8364107 - Flags: review?(bas)
(Assignee)

Updated

4 years ago
Attachment #8364107 - Flags: review?(gwright)
Attachment #8364107 - Flags: review?(bas) → review+
https://hg.mozilla.org/mozilla-central/rev/af39c4df306f
Assignee: nobody → romaxa
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Comment on attachment 8364107 [details] [diff] [review]
Qt Azure skia content render, minor refactor for shared functionalityattachment.cgiid=8363381

Clearing review flag as Bas already r+d it
Attachment #8364107 - Flags: review?(gwright)
You need to log in before you can comment on or make changes to this bug.