840943 - [Bluetooth] UI gets confused during connect/disconnect

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Bluetooth, defect)

Description

[Thomas Zimmermann [:tzimmermann] [:tdz]]

While trying to reproduce bug 838212, I noticed that the Bluetooth UI gets confused about the internal state of the connection.

STR:

 - pair phone with a Bluetooth headset
 - tap connect/disconnect button several times in a row before operation has completed

Expected result:

  - phone and head set should (dis-)connect correctly

Actual result:

  - phone gets confused about the connection status and displays warnings

I have to unpair the device, turn off Bluetooth and restart the phone to get the headset working again. Maybe this is also in internal problem within the Bluetooth system, but I think the connect button should not allow several parallel connection attempts.

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: Return success on connect operation if connection already exists

I'm not sure if this is more a problem in the Bluetooth app or the platform. This patch for the Bluetooth sub-sys at least fixes the problem for me.

Comment 2

[Thomas Zimmermann [:tzimmermann] [:tdz]]

FYI: the call to OnConnectSuccess(); in the patch once crashed my phone. I'll supply an update next week.

Comment 3

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: Return success on connect operation if connection already exists

Comment 4

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8174

Comment 5

[Eric Chou [:ericchou] [:echou]]

Comment on attachment 715151 [details] [diff] [review]
Return success on connect operation if connection already exists

Review of attachment 715151 [details] [diff] [review]:
-----------------------------------------------------------------

My original idea was, returning false to indicate this /Connect procedure/ does not complete, or does not even begin. In addition, in this case, returning true conveys a message to applications, which is "Yes, I'm connecting/connected with you." But in reality it may not be true since we don't check if current connecting/connected device is aDevicePath.

Is the original problem really caused by this returning value?

Comment 6

[Evelyn Hung]

Comment on attachment 715152 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8174

I won't r+ this until my comment on the PR is answered.
Thanks.

Comment 7

[Evelyn Hung]

Comment on attachment 715152 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8174

according to tzimmermann's comment on Github, the patch is a Gaia side fix based on attachment 715151 [details] [diff] [review] which is r- by Eric. So I r- here too.

I'd like to separate Gaia fix to another issue to make it clear and easy to track within a bunch of commits in Gaia. If the issue still need any Gaia change, please file a follow-up issue for it.
Thank you very much.

Comment 8

[Dylan Oliver [:doliver]]

Triage: tracking+, not blocking since STR involve tapping button several times.

Comment 9

[Evelyn Hung]

We locked UI to prevent multiple tapping in a very short time on other bugs. Close this as Invalid.