840993 - Improved error reporting when creating the master and dependent bugs for a project review

Status: RESOLVED FIXED

(bugzilla.mozilla.org Graveyard :: Extensions: MozProjectReview, defect)

Description

[David Lawrence [:dkl]]

Originally I wrote the creation of one or more of the dependent bugs under a single eval {} which caused all dependent bugs to not be created if one or more failed. I have revised the code to wrap each individual bug creation inside it's own eval {} and therefore at least the other bugs can still be created. Also I let the user know inside the accompanying comment that an error occurred and which bug was the failing bug. 

Also I am adding additional information such as parent bug id in the warn message that will be recorded by Arecibo which we can use for troubleshooting when problems occur.

dkl

Comment 1

[David Lawrence [:dkl]]

Attachment: Patch to improve error handling of dependent bug creation (v1)

Comment 2

[David Lawrence [:dkl]]

Attachment: Patch to improve error handling of dependent bug creation (v2)

Comment 3

[:glob ✱]

Comment on attachment 713425 [details] [diff] [review]
Patch to improve error handling of dependent bug creation (v2)

Review of attachment 713425 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob by inspection, looks good!

there's trailing whitespace in this patch, please remove before committing.

::: extensions/MozProjectReview/Extension.pm
@@ +122,5 @@
> +        {
> +            $component = ($params->{relationship_type} eq 'Other' 
> +                          || $params->{relationship_type} eq 'Hardware Purchase')
> +                       ? 'General'
> +                       : $params->{relationship_type};

nit: the indentation of the ? and : lines is wrong.

Comment 4

[David Lawrence [:dkl]]

Thanks

Committing to: bzr+ssh://[e-mail]/bmo/4.0             
modified extensions/MozProjectReview/Extension.pm
Committed revision 8482. 

Committing to: bzr+ssh://[e-mail]/bmo/4.2             
modified extensions/MozProjectReview/Extension.pm
Committed revision 8553.