The default bug view has changed. See this FAQ.

Improved error reporting when creating the master and dependent bugs for a project review

RESOLVED FIXED

Status

()

bugzilla.mozilla.org
Extensions: MozProjectReview
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: dkl, Assigned: dkl)

Tracking

Production
x86_64
Linux

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
Originally I wrote the creation of one or more of the dependent bugs under a single eval {} which caused all dependent bugs to not be created if one or more failed. I have revised the code to wrap each individual bug creation inside it's own eval {} and therefore at least the other bugs can still be created. Also I let the user know inside the accompanying comment that an error occurred and which bug was the failing bug. 

Also I am adding additional information such as parent bug id in the warn message that will be recorded by Arecibo which we can use for troubleshooting when problems occur.

dkl
(Assignee)

Comment 1

4 years ago
Created attachment 713399 [details] [diff] [review]
Patch to improve error handling of dependent bug creation (v1)
Attachment #713399 - Flags: review?(glob)
(Assignee)

Comment 2

4 years ago
Created attachment 713425 [details] [diff] [review]
Patch to improve error handling of dependent bug creation (v2)
Attachment #713399 - Attachment is obsolete: true
Attachment #713399 - Flags: review?(glob)
Attachment #713425 - Flags: review?(glob)
Comment on attachment 713425 [details] [diff] [review]
Patch to improve error handling of dependent bug creation (v2)

Review of attachment 713425 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob by inspection, looks good!

there's trailing whitespace in this patch, please remove before committing.

::: extensions/MozProjectReview/Extension.pm
@@ +122,5 @@
> +        {
> +            $component = ($params->{relationship_type} eq 'Other' 
> +                          || $params->{relationship_type} eq 'Hardware Purchase')
> +                       ? 'General'
> +                       : $params->{relationship_type};

nit: the indentation of the ? and : lines is wrong.
Attachment #713425 - Flags: review?(glob) → review+
(Assignee)

Comment 4

4 years ago
Thanks

Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bmo/4.0             
modified extensions/MozProjectReview/Extension.pm
Committed revision 8482. 

Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bmo/4.2             
modified extensions/MozProjectReview/Extension.pm
Committed revision 8553.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.