841008 - Variables view should expose LAZY_EMPTY_DELAY

Status: RESOLVED FIXED

Description

[Victor Porof [:vporof][:vp]]

Flicker delays are specific to VariablesView consumers. See bug 808370.

Comment 1

[Victor Porof [:vporof][:vp]]

Created attachment 718870 [details] [diff] [review]
v1

Mihai, maybe you can use this directly in bug 808370 before landing it? :)

Comment 2

[Mihai Sucan [:msucan]]

Comment on attachment 718870 [details] [diff] [review]
v1

Looks good. Thank you!

Yet, I am not sure how long the delay should be for the web console. We shouldn't have to arbitrarily increase such delays to avoid flickers. Variables view should handle anti-flickering on its own.

Comment 3

[Victor Porof [:vporof][:vp]]

(In reply to Mihai Sucan [:msucan] from comment #2)
> 
> Yet, I am not sure how long the delay should be for the web console. We
> shouldn't have to arbitrarily increase such delays to avoid flickers.
> Variables view should handle anti-flickering on its own.

As discussed on IRC, that's not really possible. Flickers are simply caused by the delay between an empty() call and the first scope/var/prop appending in the view.
Because since there's no way for the view to know much time it may take between those two operations, it simply relies on a timeout to swap views, or "swap buffers" (the implementation is essentially just dumb double buffering).

That said, we could enhance the current behavior to something like "yeah, delay the emptying, but flush/force redraw the contents as soon as the first thing was appended in the view". However, I think this is mostly engineering things and wouldn't result in drastic (or even measurable) improvements.

Comment 4

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/e2b00ff7e24f

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/mozilla-central/rev/e2b00ff7e24f