841082 - [Contacts] The "sort by last name" switcher is not initialised correctly

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[alberto.pastor]

STR:

1.- Open Contacts app
2.- Go to Settings
3.- Enable "order by last name"
4.- Kill the app
5.- Repeat the process and check the switcher

Expected:
The switcher is enabled

Actual:
The switcher is disabled

Comment 1

[Alex Keybl [:akeybl]]

We'd block on broken functionality, but not broken reported status. Adding qawanted to verify which it is (setting doesn't work, or setting doesn't display properly).

Comment 2

[Tony Chung [:tchung]]

I just tested this; STR in comment 0 holds true if only if you kill the contacts app.  Otherwise the last name switcher works as expected as long as contacts app is open.

But I agree this should be tef+'d, because its easy to force kill the contacts app.  Once that app is restarted, the setting does not persist.  This will mess up people's expected contacts configuration, so i nominate it to block and fix for this release.

Tested on:
Gecko  http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/d1288313218e
Gaia   6544fdb8dddc56f1aefe94482402488c89eeec49
BuildID 20130214070203
Version 18.0

Comment 3

[Dylan Oliver [:doliver]]

The setting is persisted, it's just the reporting of it that is incorrect. My contacts are still sorted by last name when I re-launch the app, but if I go into settings the toggle is in the wrong position.

If you want to return to sort by first name then you have to hit the toggle twice, which is annoying but not something I'd block on.

Comment 4

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v1

Comment 5

[Jose Manuel Cantera]

https://github.com/mozilla-b2g/gaia/commit/fddf445e09d92a8acc5c445e4e189bfe87fe0cb6

Comment 6

[Jose Manuel Cantera]

Comment on attachment 715068 [details]
Patch v1

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Contact settings latest improvements left this check outdated
User impact if declined: very high
Testing completed: yes
Risk to taking this patch (and alternatives if risky): Very low risk. Alternative is a mal-functioning app. this should be blocking, we believe.

Comment 7

[Maria Angeles Oteo (:oteo)]

Removing the approval-gaia-v1 request. This bug should be marked as tef+ (agree with Tony) and should be landed therefore in v1.0.1

Comment 8

[Daniel Coloma:dcoloma]

I don't care if it is tef+ or not, but this should land from TElefonica perspective in 1.0.1

Comment 9

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 715068 [details]
Patch v1

[Triage Comment]
Approving for uplift, as it is a reporting issue and not a functionality issue this is not a blocker but we can uplift this low risk fix for v1.0.1

Comment 10

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train@87d08b8
v1.0.1@3d463e9