841129 - Intermittent browser_repeated_messages_accuracy.js | two repeats for the second css warning - Got 1, expected 2

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=19692178&tree=Mozilla-Inbound

Rev5 MacOSX Mountain Lion 10.8 mozilla-inbound debug test mochitest-browser-chrome on 2013-02-12 21:18:20 PST for push e6ca584f4fe7
slave: talos-mtnlion-r5-041

TEST-PASS | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_repeated_messages_accuracy.js | message repeats increased
TEST-PASS | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_repeated_messages_accuracy.js | two css warnings after reload
TEST-PASS | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_repeated_messages_accuracy.js | two repeats for the first css warning
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_repeated_messages_accuracy.js | two repeats for the second css warning - Got 1, expected 2
Stack trace:
    JS frame :: chrome://mochikit/content/browser-test.js :: test_is :: line 483
    JS frame :: chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_repeated_messages_accuracy.js :: testCSSRepeatsAfterReload :: line 68
    JS frame :: chrome://mochitests/content/browser/browser/devtools/webconsole/test/head.js :: wait :: line 301
    JS frame :: chrome://mochitests/content/browser/browser/devtools/webconsole/test/head.js :: <TOP_LEVEL> :: line 304
    native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0

Comment 1

[Legacy TBPL/Treeherder Robot]

edmorley
https://tbpl.mozilla.org/php/getParsedLog.php?id=19730533&tree=Mozilla-Inbound
Rev5 MacOSX Mountain Lion 10.8 mozilla-inbound debug test mochitest-browser-chrome on 2013-02-14 01:05:27
slave: talos-mtnlion-r5-086

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_repeated_messages_accuracy.js | two repeats for the second css warning - Got 1, expected 2

Comment 2

[Legacy TBPL/Treeherder Robot]

msucan
https://tbpl.mozilla.org/php/getParsedLog.php?id=21320925&tree=Try
Rev3 Fedora 12x64 try opt test mochitest-browser-chrome on 2013-04-01 13:03:38
slave: talos-r3-fed64-071

13:23:09  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_repeated_messages_accuracy.js | two repeats for the second css warning - Got 1, expected 2

Comment 3

[Mihai Sucan [:msucan]]

Attachment: proposed fix

Problem: This test generates several errors and warnings that need to be coalesced. waitForSuccess() waits until the two css warnings are displayed, but it doesn't check if the two messages have two repeats. Sometimes successFn() is executed too early, before the last css warning comes into the web console, before the output is updated. This is why the test fails in rare cases: it finds the messages but they don't have the expected number of repeats (yet).

The fix is to wait until the expected number of messages *and* repeats are found.

Comment 4

[Mihai Sucan [:msucan]]

Green try push https://tbpl.mozilla.org/?tree=Try&rev=e793ae2be4f6

Comment 5

[Victor Porof [:vporof][:vp]]

Comment on attachment 732756 [details] [diff] [review]
proposed fix

Review of attachment 732756 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Comment 6

[Mihai Sucan [:msucan]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1c11f604c369

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1c11f604c369