Closed Bug 841129 Opened 7 years ago Closed 7 years ago

Intermittent browser_repeated_messages_accuracy.js | two repeats for the second css warning - Got 1, expected 2

Categories

(DevTools :: Console, defect)

x86_64
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 23

People

(Reporter: RyanVM, Assigned: msucan)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

https://tbpl.mozilla.org/php/getParsedLog.php?id=19692178&tree=Mozilla-Inbound

Rev5 MacOSX Mountain Lion 10.8 mozilla-inbound debug test mochitest-browser-chrome on 2013-02-12 21:18:20 PST for push e6ca584f4fe7
slave: talos-mtnlion-r5-041

TEST-PASS | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_repeated_messages_accuracy.js | message repeats increased
TEST-PASS | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_repeated_messages_accuracy.js | two css warnings after reload
TEST-PASS | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_repeated_messages_accuracy.js | two repeats for the first css warning
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_repeated_messages_accuracy.js | two repeats for the second css warning - Got 1, expected 2
Stack trace:
    JS frame :: chrome://mochikit/content/browser-test.js :: test_is :: line 483
    JS frame :: chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_repeated_messages_accuracy.js :: testCSSRepeatsAfterReload :: line 68
    JS frame :: chrome://mochitests/content/browser/browser/devtools/webconsole/test/head.js :: wait :: line 301
    JS frame :: chrome://mochitests/content/browser/browser/devtools/webconsole/test/head.js :: <TOP_LEVEL> :: line 304
    native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
Attached patch proposed fixSplinter Review
Problem: This test generates several errors and warnings that need to be coalesced. waitForSuccess() waits until the two css warnings are displayed, but it doesn't check if the two messages have two repeats. Sometimes successFn() is executed too early, before the last css warning comes into the web console, before the output is updated. This is why the test fails in rare cases: it finds the messages but they don't have the expected number of repeats (yet).

The fix is to wait until the expected number of messages *and* repeats are found.
Assignee: nobody → mihai.sucan
Status: NEW → ASSIGNED
Attachment #732756 - Flags: review?(vporof)
Comment on attachment 732756 [details] [diff] [review]
proposed fix

Review of attachment 732756 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #732756 - Flags: review?(vporof) → review+
https://hg.mozilla.org/mozilla-central/rev/1c11f604c369
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.