841132 - jsscript.cpp:423:16: warning: variable ‘notes’ set but not used [-Wunused-but-set-variable]

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Daniel Holbert [:dholbert]]

Build warning:
{
js/src/jsscript.cpp:423:16: warning: variable ‘notes’ set but not used [-Wunused-but-set-variable]

I *think* the last usage of this variable was this code, for bug 571249:
> for (sn = notes; !SN_IS_TERMINATOR(sn); sn = SN_NEXT(sn))
which was removed here:
https://hg.mozilla.org/mozilla-central/diff/b35005673847/js/src/jsscript.cpp#l1.30

...though that was a long time ago, so maybe there was another more-recently-removed usage that I'm missing.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix v1 (w/ some accidental unrelated debugging code)

Comment 2

[Daniel Holbert [:dholbert]]

sorry, that patch included some unrelated debugging code. reposting.

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: fix v1a

Comment 4

[Nicholas Nethercote [inactive]]

Comment on attachment 713584 [details] [diff] [review]
fix v1a

Review of attachment 713584 [details] [diff] [review]:
-----------------------------------------------------------------

It was bug 679940.  Looks ok to me but I'll ask Till for review, since he did bug 679940, and this might suggest some additional cleanups.

Comment 5

[Till Schneidereit [:till]]

Comment on attachment 713584 [details] [diff] [review]
fix v1a

Review of attachment 713584 [details] [diff] [review]:
-----------------------------------------------------------------

sorry about that, clang's usage warnings don't seem to be triggered by write-only usage. Or I'm just blind. Probably the latter, so take me not seeing more cleanup opportunities with a grain of salt.

Comment 6

[Daniel Holbert [:dholbert]]

no worries / thanks!

(If there end up being more cleanup opportunities that we discover later, I'm sure we can deal with them in other bugs. In the meantime, this is the only GCC 4.7 build warning that I get for this file.)

Comment 7

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e5694309feed

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e5694309feed