841146 - js/src/ion/ParallelArrayAnalysis.cpp:72:29: warning: private field 'compileContext_' is not used [-Wunused-private-field]

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Daniel Holbert [:dholbert]]

New clang build warning:
{
js/src/ion/ParallelArrayAnalysis.cpp:72:29: warning: private field 'compileContext_' is not used [-Wunused-private-field]
}

This was added in https://hg.mozilla.org/mozilla-central/rev/80a21124ddbd for bug 807853.

Niko: is this variable going intentionally-unused, & intended to be used at some point in the future?

If not, then we should drop it; but if so, then we can suppress the build warning w/ a (void) cast.

Comment 1

[Daniel Holbert [:dholbert]]

Link to source, for reference:
 https://mxr.mozilla.org/mozilla-central/source/js/src/ion/ParallelArrayAnalysis.cpp#72

Comment 2

[Niko Matsakis [:nmatsakis]]

I think it is simply unused and can be removed.

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: fix v1

Comment 4

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/659e228ab14f

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/659e228ab14f