Closed Bug 841150 Opened 12 years ago Closed 12 years ago

Intermittent test_peerConnection_basicAudio.html, test_peerConnection_basicAudioVideo.html, test_peerConnection_basicAudioVideoCombined.html, test_peerConnection_basicVideo.html, test_peerConnection_bug827843.html | Unexpected error callback with 0

Categories

(Core :: WebRTC: Audio/Video, defect, P5)

Product:
Core
Component:
WebRTC: Audio/Video
Platform:
x86_64
Linux
Type:
defect

Tracking

()

Status:
RESOLVED INCOMPLETE

People

(Reporter: RyanVM, Assigned: abr)

References

Details

(Keywords: intermittent-failure, Whiteboard: [webrtc][blocking-webrtc-])

https://tbpl.mozilla.org/php/getParsedLog.php?id=19707192&tree=Mozilla-Inbound Rev3 Fedora 12x64 mozilla-inbound opt test mochitest-3 on 2013-02-13 11:10:19 PST for push 872af2305af3 slave: talos-r3-fed64-068 293 INFO TEST-START | /tests/dom/media/tests/mochitest/test_peerConnection_basicAudio.html 294 INFO TEST-INFO | /tests/dom/media/tests/mochitest/test_peerConnection_basicAudio.html | Calling addStream on local peer connection 295 INFO TEST-INFO | /tests/dom/media/tests/mochitest/test_peerConnection_basicAudio.html | Calling addStream on remote peer connection 296 INFO TEST-INFO | /tests/dom/media/tests/mochitest/test_peerConnection_basicAudio.html | Calling createOffer on local peer connection 297 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/media/tests/mochitest/test_peerConnection_basicAudio.html | Unexpected error callback with 0 298 INFO TEST-END | /tests/dom/media/tests/mochitest/test_peerConnection_basicAudio.html | finished in 396ms 299 INFO TEST-START | /tests/dom/media/tests/mochitest/test_peerConnection_basicAudioVideo.html 300 INFO TEST-INFO | /tests/dom/media/tests/mochitest/test_peerConnection_basicAudioVideo.html | Calling addStream on local peer connection with audio stream 301 INFO TEST-INFO | /tests/dom/media/tests/mochitest/test_peerConnection_basicAudioVideo.html | Calling addStream on local peer connection with video stream 302 INFO TEST-INFO | /tests/dom/media/tests/mochitest/test_peerConnection_basicAudioVideo.html | Calling addStream on remote peer connection with audio stream 303 INFO TEST-INFO | /tests/dom/media/tests/mochitest/test_peerConnection_basicAudioVideo.html | Calling addStream on remote peer connection with video stream 304 INFO TEST-INFO | /tests/dom/media/tests/mochitest/test_peerConnection_basicAudioVideo.html | Calling createOffer on local peer connection 305 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/media/tests/mochitest/test_peerConnection_basicAudioVideo.html | Unexpected error callback with 0 306 INFO TEST-END | /tests/dom/media/tests/mochitest/test_peerConnection_basicAudioVideo.html | finished in 231ms 307 INFO TEST-START | /tests/dom/media/tests/mochitest/test_peerConnection_basicAudioVideoCombined.html 308 INFO TEST-INFO | /tests/dom/media/tests/mochitest/test_peerConnection_basicAudioVideoCombined.html | Calling addStream on local peer connection 309 INFO TEST-INFO | /tests/dom/media/tests/mochitest/test_peerConnection_basicAudioVideoCombined.html | Calling addStream on remote peer connection 310 INFO TEST-INFO | /tests/dom/media/tests/mochitest/test_peerConnection_basicAudioVideoCombined.html | Calling createOffer on local peer connection 311 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/media/tests/mochitest/test_peerConnection_basicAudioVideoCombined.html | Unexpected error callback with 0 312 INFO TEST-END | /tests/dom/media/tests/mochitest/test_peerConnection_basicAudioVideoCombined.html | finished in 229ms 313 INFO TEST-START | /tests/dom/media/tests/mochitest/test_peerConnection_basicVideo.html 314 INFO TEST-INFO | /tests/dom/media/tests/mochitest/test_peerConnection_basicVideo.html | Calling addStream on local peer connection 315 INFO TEST-INFO | /tests/dom/media/tests/mochitest/test_peerConnection_basicVideo.html | Calling addStream on remote peer connection 316 INFO TEST-INFO | /tests/dom/media/tests/mochitest/test_peerConnection_basicVideo.html | Calling createOffer on local peer connection 317 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/media/tests/mochitest/test_peerConnection_basicVideo.html | Unexpected error callback with 0 318 INFO TEST-END | /tests/dom/media/tests/mochitest/test_peerConnection_basicVideo.html | finished in 258ms 319 INFO TEST-START | /tests/dom/media/tests/mochitest/test_peerConnection_bug825703.html 320 INFO TEST-PASS | /tests/dom/media/tests/mochitest/test_peerConnection_bug825703.html | mozRTCPeerConnection() succeeds 321 INFO TEST-PASS | /tests/dom/media/tests/mochitest/test_peerConnection_bug825703.html | mozRTCPeerConnection(1) throws 322 INFO TEST-PASS | /tests/dom/media/tests/mochitest/test_peerConnection_bug825703.html | mozRTCPeerConnection({}) throws 323 INFO TEST-PASS | /tests/dom/media/tests/mochitest/test_peerConnection_bug825703.html | mozRTCPeerConnection([]) throws 324 INFO TEST-PASS | /tests/dom/media/tests/mochitest/test_peerConnection_bug825703.html | mozRTCPeerConnection({ iceServers: {}}) throws 325 INFO TEST-PASS | /tests/dom/media/tests/mochitest/test_peerConnection_bug825703.html | mozRTCPeerConnection({ iceServers: [] }) succeeds 326 INFO TEST-PASS | /tests/dom/media/tests/mochitest/test_peerConnection_bug825703.html | mozRTCPeerConnection({ iceServers: [{ url:"" }] }) throws 327 INFO TEST-PASS | /tests/dom/media/tests/mochitest/test_peerConnection_bug825703.html | mozRTCPeerConnection({ iceServers: [{ url:"http:0.0.0.0" }] }) throws 328 INFO TEST-PASS | /tests/dom/media/tests/mochitest/test_peerConnection_bug825703.html | mozRTCPeerConnection({ iceServers: [{ url:"stun:0.0.0.0" }, { url:"stuns:x.net", foo:"" }, { url: "turn:[::192.9.5.5]:42" }, { url:"turns:user@x.org:42", credential:"p" }] }) succeeds 329 INFO TEST-PASS | /tests/dom/media/tests/mochitest/test_peerConnection_bug825703.html | mozRTCPeerConnection({ iceServers: [{ url:"stun:0.0.0.0", credential:{}}] }) throws 330 INFO TEST-END | /tests/dom/media/tests/mochitest/test_peerConnection_bug825703.html | finished in 642ms 331 INFO TEST-START | /tests/dom/media/tests/mochitest/test_peerConnection_bug827843.html 332 INFO TEST-INFO | /tests/dom/media/tests/mochitest/test_peerConnection_bug827843.html | Calling createOffer on local peer connection 333 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/media/tests/mochitest/test_peerConnection_bug827843.html | Unexpected error callback with 0 334 INFO TEST-END | /tests/dom/media/tests/mochitest/test_peerConnection_bug827843.html | finished in 238ms 335 INFO TEST-START | /tests/dom/media/tests/mochitest/test_peerConnection_bug834153.html 336 INFO TEST-PASS | /tests/dom/media/tests/mochitest/test_peerConnection_bug834153.html | pc1 is non-null 337 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/media/tests/mochitest/test_peerConnection_bug834153.html | createOffer failed: 0 338 INFO TEST-END | /tests/dom/media/tests/mochitest/test_peerConnection_bug834153.html | finished in 281ms
Looks like the sipcc system didn't initialize correctly, probably related to the race in Bug 823056. That fix only prevented pointers from getting corrupted; there is still a narrow path by which the sipcc thread might get ahead of the main thread and cause initialization to fail.
Assignee: nobody → adam
Whiteboard: [webrtc][blocking-webrtc+]
Depends on: 841566, 841457
Capturing this from IRC logs: "The problem with Bug 839647 / Bug 841150 is the race between the main thread and the CCApp thread that starts in CallControlManagerImpl::startSDPMode. Based on a conversation with jesup last night, I tried synchronizing things with this change: http://pastebin.mozilla.org/2145788 . This does ensure that the CCApp thread doesn't process any messages until the main thread is done with its init, but the net result is that Bug 839647 goes from intermittent to 100%."
I believe that the patch attached to Bug 839347 probably resolves this issue. I plan to keep this open for a while after that patch lands. If it doesn't re-surface, I think we can presume that the CCApp init synchronization fix addresses this bug as well.
Status: NEW → ASSIGNED
Closing on the premise that we believe the issue to be addressed by a landed patch.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [webrtc][blocking-webrtc+] → [webrtc][blocking-webrtc+][qa-]
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: [webrtc][blocking-webrtc+][qa-] → [webrtc][blocking-webrtc+]
Priority: -- → P3
Adam - is this the same bug, or a different bug with the same signature?
Whiteboard: [webrtc][blocking-webrtc+] → [webrtc][blocking-webrtc-]
(In reply to Randell Jesup [:jesup] from comment #7) > Adam - is this the same bug, or a different bug with the same signature? It's hard to tell. In reading the code, there are only four places an offer error can originate right now. In reading down all four codepaths, they all seem quite improbable as intermittent errors: * One only happens for session renegotiation. * One only happens if the SDP lacks ice-ufrag: or ice-pwd: attributes. * One only arises if the generated SDP has no M lines (or various things that can never be NULL actually are). * One only happens, again, if various things that can never be NULL actually are. That's a pretty big haystack to go rooting around in. Luckily, now that Bug 860012 has landed, any recurrence of this bug will contain a very specific indication of which of these four rather improbable things have actually happened. Until it pops up again, I'm happy leaving this bug on a back burner.
Priority: P3 → P5
If the bug itself isn't actionable until we get a reproduction again, let's close this for now as incomplete. If it reproduces again, reopen it and we'll do more analysis here to diagnose.
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.