841249 - [Robocop] Tests for distribution preferences

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[:Margaret Leibovic]

In preferences.json, you can specify preferences like this:

  "Preferences": {
    "distribution.test.string": "my test string pref",
    "distribution.test.boolean": true,
    "distribution.test.int": 5
  }

We should make sure this works. Once bug 840825 lands, it should be pretty simple to add this testcase there.

Comment 1

[Mark Capella [:capella]]

Attachment: Patch (v1)

First try, small patch.

Comment 2

[:Margaret Leibovic]

Comment on attachment 718135 [details] [diff] [review]
Patch (v1)

Review of attachment 718135 [details] [diff] [review]:
-----------------------------------------------------------------

Nice! Thanks for helping out. I was about to say that you need to update mock-package.zip, but then I realized that we're already setting these prefs in there, which is cool.

::: mobile/android/base/tests/testDistribution.java.in
@@ +120,3 @@
>                  }
>              }
> +            mAsserter.is(mTestPrefCount, TEST_PREF_STORED, "check all stored preferences found");

Is there any reason we wouldn't get all 6 preferences back? Could we just check that preferences.length() is 6? If we do decide to explicitly check that we checked each preference, I think we could just make a local testPrefCount variable, instead of making a member variable for the count.

Comment 3

[Mark Capella [:capella]]

I can remove that ... I had put that in during testing various options and accidentally misnamed a pref ... for finalized / controlled tests like this getting back preferences we've explicitly set should be a safe assumption.

Comment 4

[Mark Capella [:capella]]

Attachment: Patch (v2)

Removed prefs counting test ...

Comment 5

[Mark Capella [:capella]]

Push to TRY:
https://tbpl.mozilla.org/?tree=Try&rev=44f62f297012

Comment 6

[Mark Capella [:capella]]

And on to inbound:
http://hg.mozilla.org/integration/mozilla-inbound/rev/62f32eb94356

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/62f32eb94356