Closed Bug 841406 Opened 7 years ago Closed 7 years ago

Remove enablePrivilege from tests added in bug 739217

Categories

(Toolkit :: Places, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla22

People

(Reporter: bholley, Assigned: andreshm)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

I was just grepping through the commit log, and it appears that bug 739217 added nontrivial usage of enablePrivilege. That API is dangerous and deprecated, and per jst's decree new code may not add usage of enablePrivilege. The replacement API is SpecialPowers. :-)

Andres or mak, can one of you guys take ownership of fixing the tests?
Assignee: nobody → andres
Attached patch Patch v1Splinter Review
Currently, the mochitest browser and plain files were sharing the same head.js. With this patch there is a new head_plain.js, so enablePrivilege is not needed anymore.
Attachment #714561 - Flags: review?(mak77)
Status: NEW → ASSIGNED
Comment on attachment 714561 [details] [diff] [review]
Patch v1

Review of attachment 714561 [details] [diff] [review]:
-----------------------------------------------------------------

So, if I got this right, you copied head.js to head_plain.js, removed from head.js the no more useful enablePrivileges, and removed any privileged code from head_plain.js
This looks fine.
Attachment #714561 - Flags: review?(mak77) → review+
https://hg.mozilla.org/mozilla-central/rev/4d3142a9b14b
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.