Remove enablePrivilege from tests added in bug 739217

RESOLVED FIXED in mozilla22

Status

()

Toolkit
Places
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bholley, Assigned: andreshm)

Tracking

(Blocks: 1 bug)

unspecified
mozilla22
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
I was just grepping through the commit log, and it appears that bug 739217 added nontrivial usage of enablePrivilege. That API is dangerous and deprecated, and per jst's decree new code may not add usage of enablePrivilege. The replacement API is SpecialPowers. :-)

Andres or mak, can one of you guys take ownership of fixing the tests?
(Assignee)

Updated

5 years ago
Assignee: nobody → andres
(Assignee)

Comment 1

5 years ago
Created attachment 714561 [details] [diff] [review]
Patch v1

Currently, the mochitest browser and plain files were sharing the same head.js. With this patch there is a new head_plain.js, so enablePrivilege is not needed anymore.
Attachment #714561 - Flags: review?(mak77)
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED
Comment on attachment 714561 [details] [diff] [review]
Patch v1

Review of attachment 714561 [details] [diff] [review]:
-----------------------------------------------------------------

So, if I got this right, you copied head.js to head_plain.js, removed from head.js the no more useful enablePrivileges, and removed any privileged code from head_plain.js
This looks fine.
Attachment #714561 - Flags: review?(mak77) → review+
(Assignee)

Comment 4

5 years ago
All green on try: https://tbpl.mozilla.org/?tree=Try&rev=d1cadae83636
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/4d3142a9b14b
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.