841406 - Remove enablePrivilege from tests added in bug 739217

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Bobby Holley (:bholley)]

I was just grepping through the commit log, and it appears that bug 739217 added nontrivial usage of enablePrivilege. That API is dangerous and deprecated, and per jst's decree new code may not add usage of enablePrivilege. The replacement API is SpecialPowers. :-)

Andres or mak, can one of you guys take ownership of fixing the tests?

Comment 1

[Andres Hernandez [:andreshm]]

Attachment: Patch v1

Currently, the mochitest browser and plain files were sharing the same head.js. With this patch there is a new head_plain.js, so enablePrivilege is not needed anymore.

Comment 2

[Marco Bonardo [:mak]]

Comment on attachment 714561 [details] [diff] [review]
Patch v1

Review of attachment 714561 [details] [diff] [review]:
-----------------------------------------------------------------

So, if I got this right, you copied head.js to head_plain.js, removed from head.js the no more useful enablePrivileges, and removed any privileged code from head_plain.js
This looks fine.

Comment 3

[Andres Hernandez [:andreshm]]

Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=d1cadae83636

Comment 4

[Andres Hernandez [:andreshm]]

All green on try: https://tbpl.mozilla.org/?tree=Try&rev=d1cadae83636

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4d3142a9b14b

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4d3142a9b14b