make nsDocLoader::mChildList a TArray not a nsVoidArray

RESOLVED FIXED in Firefox 22

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: tbsaunde, Assigned: tbsaunde)

Tracking

unspecified
mozilla21
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox21 disabled, firefox22 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

6 years ago
Created attachment 713983 [details] [diff] [review]
use a TArray for nsDocLoader::mChildList
Attachment #713983 - Flags: review?(bzbarsky)
Comment on attachment 713983 [details] [diff] [review]
use a TArray for nsDocLoader::mChildList

>+++ b/docshell/base/nsDocShell.cpp
>@@ -3476,32 +3476,32 @@ nsDocShell::AddChild(nsIDocShellTreeItem * aChild)

>-    childDocShell->SetChildOffset(dynamic ? -1 : mChildList.Count() - 1);
>+    childDocShell->SetChildOffset(dynamic ? -1 : mChildList.Length() - 1);

Is this OK when mChildList is empty?  I guess we were already coercing to uint32_t in the callee, so maybe it's fine.

r=me
Attachment #713983 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/8ddc33231c6f
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21

Updated

6 years ago
Depends on: 842078
Depends on: 845429
(In reply to Trevor Saunders (:tbsaunde) from comment #3)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/8ddc33231c6f

Should the target milestone be changed to 22 or marked disabled on Fx21 as this was backed out on aurora?
Backed out for Fx21 due to bug 842078.
https://hg.mozilla.org/releases/mozilla-aurora/rev/954fbeed220c
status-firefox21: --- → disabled
status-firefox22: --- → fixed
You need to log in before you can comment on or make changes to this bug.