Closed
Bug 841434
Opened 11 years ago
Closed 11 years ago
make nsDocLoader::mChildList a TArray not a nsVoidArray
Categories
(Core :: DOM: Navigation, defect)
Core
DOM: Navigation
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: tbsaunde, Assigned: tbsaunde)
References
Details
Attachments
(1 file)
20.60 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #713983 -
Flags: review?(bzbarsky)
Comment 2•11 years ago
|
||
Comment on attachment 713983 [details] [diff] [review] use a TArray for nsDocLoader::mChildList >+++ b/docshell/base/nsDocShell.cpp >@@ -3476,32 +3476,32 @@ nsDocShell::AddChild(nsIDocShellTreeItem * aChild) >- childDocShell->SetChildOffset(dynamic ? -1 : mChildList.Count() - 1); >+ childDocShell->SetChildOffset(dynamic ? -1 : mChildList.Length() - 1); Is this OK when mChildList is empty? I guess we were already coercing to uint32_t in the callee, so maybe it's fine. r=me
Attachment #713983 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/8ddc33231c6f
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8ddc33231c6f
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
Comment 5•11 years ago
|
||
(In reply to Trevor Saunders (:tbsaunde) from comment #3) > https://hg.mozilla.org/integration/mozilla-inbound/rev/8ddc33231c6f Should the target milestone be changed to 22 or marked disabled on Fx21 as this was backed out on aurora?
Comment 6•11 years ago
|
||
Backed out for Fx21 due to bug 842078. https://hg.mozilla.org/releases/mozilla-aurora/rev/954fbeed220c
status-firefox21:
--- → disabled
status-firefox22:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•