Closed Bug 841434 Opened 11 years ago Closed 11 years ago

make nsDocLoader::mChildList a TArray not a nsVoidArray

Categories

(Core :: DOM: Navigation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla21
Tracking Status
firefox21 --- disabled
firefox22 --- fixed

People

(Reporter: tbsaunde, Assigned: tbsaunde)

References

Details

Attachments

(1 file)

      No description provided.
Attachment #713983 - Flags: review?(bzbarsky)
Comment on attachment 713983 [details] [diff] [review]
use a TArray for nsDocLoader::mChildList

>+++ b/docshell/base/nsDocShell.cpp
>@@ -3476,32 +3476,32 @@ nsDocShell::AddChild(nsIDocShellTreeItem * aChild)

>-    childDocShell->SetChildOffset(dynamic ? -1 : mChildList.Count() - 1);
>+    childDocShell->SetChildOffset(dynamic ? -1 : mChildList.Length() - 1);

Is this OK when mChildList is empty?  I guess we were already coercing to uint32_t in the callee, so maybe it's fine.

r=me
Attachment #713983 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/8ddc33231c6f
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
Depends on: 845429
(In reply to Trevor Saunders (:tbsaunde) from comment #3)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/8ddc33231c6f

Should the target milestone be changed to 22 or marked disabled on Fx21 as this was backed out on aurora?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: