If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Mask text and selection updates when handling IME_REMOVE_COMPOSITION

RESOLVED FIXED in Firefox 21

Status

()

Firefox for Android
Keyboards and IME
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jchen, Assigned: jchen)

Tracking

unspecified
Firefox 21
ARM
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 714056 [details] [diff] [review]
Mask events when removing composition (v1)

Similar to the handling of IME_UPDATE_COMPOSITION, when we handle IME_REMOVE_COMPOSITION, we should mask text and selection updates generated as part of clearing the composition.
Attachment #714056 - Flags: review?(cpeterson)
Comment on attachment 714056 [details] [diff] [review]
Mask events when removing composition (v1)

Review of attachment 714056 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

::: widget/android/nsWindow.cpp
@@ +1964,5 @@
> +                  visual indication and does not affect the text content.
> +
> +                Selection and text updates are masked so the result of
> +                  temporary events are not passed on to Java
> +            */

// We
// should
// use
// C++-style
// multiline
// comments
// like
// this
/*
 * or
 * C-style
 * multiline
 * comments
 * like
 * this.
 */
Attachment #714056 - Flags: review?(cpeterson) → review+
(Assignee)

Comment 3

5 years ago
Changed comment style

https://hg.mozilla.org/integration/mozilla-inbound/rev/3bd8f038263d
Target Milestone: --- → Firefox 21

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/3bd8f038263d
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.