841507 - Mask text and selection updates when handling IME_REMOVE_COMPOSITION

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Keyboards and IME, defect)

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Mask events when removing composition (v1)

Similar to the handling of IME_UPDATE_COMPOSITION, when we handle IME_REMOVE_COMPOSITION, we should mask text and selection updates generated as part of clearing the composition.

Comment 2

[Chris Peterson [:cpeterson]]

Comment on attachment 714056 [details] [diff] [review]
Mask events when removing composition (v1)

Review of attachment 714056 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

::: widget/android/nsWindow.cpp
@@ +1964,5 @@
> +                  visual indication and does not affect the text content.
> +
> +                Selection and text updates are masked so the result of
> +                  temporary events are not passed on to Java
> +            */

// We
// should
// use
// C++-style
// multiline
// comments
// like
// this
/*
 * or
 * C-style
 * multiline
 * comments
 * like
 * this.
 */

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Changed comment style

https://hg.mozilla.org/integration/mozilla-inbound/rev/3bd8f038263d

Comment 4

[Gregory Szorc [:gps]]

https://hg.mozilla.org/mozilla-central/rev/3bd8f038263d