Closed
Bug 84175
Opened 24 years ago
Closed 24 years ago
nsHTMLEditor::IsEmptyCell should be rewritten
Categories
(Core :: DOM: Editor, defect)
Core
DOM: Editor
Tracking
()
CLOSED
FIXED
mozilla0.9.2
People
(Reporter: Brade, Assigned: cmanske)
References
Details
Attachments
(2 files)
|
804 bytes,
patch
|
Details | Diff | Splinter Review | |
|
1.16 KB,
patch
|
Details | Diff | Splinter Review |
I noticed these things when looking at the source code for
nsHTMLEditor::IsEmptyCell (in nsTableEditor.cpp):
* the method returns a PRBool, but we return an nsresult if we get an error
after called GetFirstChild.
* we don't do any further error checking (we get "res" in the call to
GetNextSibling but we ignore that value and we don't even get it for
"IsEmptyNode" call
|
Assignee | |
Comment 1•24 years ago
|
||
|
|
Assignee | |
Comment 2•24 years ago
|
||
easy fix.
|
|
Assignee | |
Comment 3•24 years ago
|
||
|
Reporter | |
Comment 4•24 years ago
|
||
r=brade
Whiteboard: FIX IN HAND need r=, sr= → FIX IN HAND need sr=, a=
Whiteboard: FIX IN HAND need sr=, a= → FIX IN HAND need a=
|
||
Comment 6•24 years ago
|
||
a= asa@mozilla.org for checkin to the trunk.
(on behalf of drivers)
|
|
||
Updated•24 years ago
|
Whiteboard: FIX IN HAND need a= → fixed, reviewed, a=asa
|
|
Assignee | |
Comment 7•24 years ago
|
||
Checked in.
Charley/Kathy, please mark verify this one and mark verified-fixed...thx.
You need to log in
before you can comment on or make changes to this bug.
Description
•