Closed Bug 84188 Opened 25 years ago Closed 25 years ago

Need to migrate existing localizable string preferences to a new pref type

Categories

(SeaMonkey :: Preferences, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
Future

People

(Reporter: jbetak, Assigned: jbetak)

Details

(Whiteboard: have fix, need sr)

Attachments

(1 file)

patch for bug 65251 will introduce a new preference type in nsPrefWindow.js. We need to migrate the existing localizable preferences to this type. The current list in lxr: browser.startup.homepage wallet.Server intl.accept_languages intl.charset.defaultmailnews.start_page.url mailnews.view_default_charset mailnews.send_default_charset http://lxr.mozilla.org/seamonkey/source/xpfe/components/prefwindow/resources/con﷒0﷓ This is an effort in risk management, the migrated prefs need to be retested in our localized builds. I'm targetting Moz 0.9.3
accepting, marking dependency on bug 65251
Status: NEW → ASSIGNED
Depends on: 65251
No longer depends on: 65251
move to moz0.9.3
Target Milestone: --- → mozilla0.9.3
no direct user impact. mark as future
Target Milestone: mozilla0.9.3 → Future
OK, got a truk patch - tao would you care to review? Ben, do you have cycles to sr?
QA Contact: sairuh → teruko
looks fine; r=tao.
moving to 0.9.3, still need sr
Whiteboard: have fix, need sr
What about wallet.Server and mailnews.start_page.url?
I double-checked and believe they are covered by the current patch. On the other hand, maybe we should include http://lxr.mozilla.org/seamonkey/source/extensions/content-packs/resources/content/pref-contentpacks.xul#64 which happens to be a mirror image of 94008. I'll go over all the prefs listed in http://lxr.mozilla.org/seamonkey/source/xpfe/components/prefwindow/resources/content/nsPrefWindow.js#148 before I check in to make sure we haven't missed anything. I'd like to get this in early to increase the discoverability of regressions before the 0.9.4 release.
sr=blake
fix checked in - thanks everyone!
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Verified as fixed.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: