841899 - Remove stream-based logging from Signaling code

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect, P3)

Description

[Ethan Hugg [:ehugg]]

The signaling code has some stream-based logging calls such as CSFLogDebugS which  are currently only active in Debug builds.  This can be confusing when trying to analyze logs from Release builds.  We need to replace all of these with their printf-style equivalents, e.g. CSFLogDebug.

Comment 1

[Ethan Hugg [:ehugg]]

Attachment: Remove stream-based logging from Signaling code

Comment 2

[Ethan Hugg [:ehugg]]

Attachment: Remove stream-based logging from Signaling code

Comment 3

[Ethan Hugg [:ehugg]]

Attachment: Remove stream-based logging from Signaling code

Comment 4

[Ethan Hugg [:ehugg]]

Comment on attachment 716606 [details] [diff] [review]
Remove stream-based logging from Signaling code


Re-based patch on latest M-I because of merge conflicts with Bug 841641

Bringing forward r+ from Jesup

Try is here:

https://tbpl.mozilla.org/?tree=Try&rev=cdc2c22a6901

Comment 5

[Ethan Hugg [:ehugg]]

Try run with -p all instead of -p none...

https://tbpl.mozilla.org/?tree=Try&rev=b8510aa237e7

Comment 6

[Ethan Hugg [:ehugg]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/be1f3e460255

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/be1f3e460255

Comment 8

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

What was gained here? Varargs are prone to error, so this seems like a step backwards.

Comment 9

[Ethan Hugg [:ehugg]]

>What was gained here? Varargs are prone to error, so this seems like a step >backwards.

Streams are not allowed in Mozilla production code.  So all of these instances that were just changed were #ifdef DEBUG which meant that some logging was on opt builds and some not.   Now it should be less confusing when trying to debug an opt build.

I agree with you of course that the streams versions would've been better to use and less prone to error in all of this CPP code and that's why they existed, but streams bad because Mozilla.